• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Index: twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm
===================================================================
--- twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm        (revision 8165)
+++ twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm        (working copy)
@@ -125,6 +125,7 @@
 use File::Copy;
 use File::Spec;
 use File::Find;
+use File::Path qw( rmtree );
 use POSIX;
 use CGI ( -any );
 use diagnostics;
@@ -356,6 +357,12 @@
     return $this;
 }

+sub DESTROY
+{
+    my $self = shift;
+    rmtree( $self->{tmpDir} ) if $self->{tmpDir};
+}
+
 sub _get_svn_version {
     my $from = shift;
     my $ver = `svn info $from`;

SVN:8217

WN


SVN:8217 is good.

However now that the /tmp/[123456789]* directories have gone I'm just left with the /tmp/lastRel* ones.

I realise that this is, strictly speaking, a tools/build.pl issue and not a BuildContrib/Build.pm issue. However from the point of view of tools/build.pl the per plugin (etc) were generated and left behind, and Will's fix addressed the lower level manifestation of a problem that was triggered by a higer level action.

I see the two issues related so I'm re-opening this item rather than creating a new, disjoint, unrelated item.

-- AJA

It's untidy, but non-fatal so I'm dropping the priority to Low.

CC

SVN 8365

CC

ItemTemplate
Summary BuildContrib doesn't clean up temp files after itself
ReportedBy WillNorris
Codebase

SVN Range Tue, 10 Jan 2006 build 8208
AppliesTo Engine
Component BuildScripts
Priority Low
CurrentState Closed
WaitingFor

Checkins 8217
Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2006-01-18 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback