• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

On a fresh install from SVN, I noticed that the top bar and left bar are visible on non-view pages (edit and attach).

http://visiblearea.com/svntwiki/DEVELOP/bin/attach/Sandbox/WebHome

I haven't noticed this on develop.

Strange is that body.pattern.tmpl writes %TMPL:P{"topbar"}%, but viewtopbar.pattern.tmpl is not included, so DEF topbar should be empty.

Somehow DEF topbar is read from viewtopbar.pattern.tmpl.

Installing with links or copied templates made no difference.

AC


It appears that the edit screen includes the view template. Because if I remove all includes from view, edit renders as normal...

AC


I am seeing this now also on my older installation where I just manually updated the lib folder. So it must be a recent change.

AC

I've been tracking this a bit, it seems the inclusion of the top bar was introduced in 9097 (?).

$ svn diff -r 9096:9097
Index: lib/TWiki/User.pm
===================================================================
--- lib/TWiki/User.pm   (revision 9096)
+++ lib/TWiki/User.pm   (revision 9097)
@@ -368,10 +368,13 @@
         unless( $this->{isKnownAdmin} ) {
             my $sag = $this->{session}->{users}->findUser(
                 $TWiki::cfg{SuperAdminGroup}, undef, 1 );
-            if (defined($sag)) {    #don't mess up the isKnownAdmin, we lazy load groups
-                ASSERT($sag->isa( 'TWiki::User')) if DEBUG;
-                $this->{isKnownAdmin} = $this->isInList( $sag->groupMembers() );
+            if (!defined($sag)) {    #force a lazy load groups
+                $this->{session}->{users}->getAllGroups();
+                $sag = $this->{session}->{users}->findUser(
+                    $TWiki::cfg{SuperAdminGroup} ); #must be undefined - create it
             }
+            ASSERT($sag->isa( 'TWiki::User')) if DEBUG;
+            $this->{isKnownAdmin} = $this->isInList( $sag->groupMembers() );
         }
     }
     return $this->{isKnownAdmin};


$ svn log -r 9097
------------------------------------------------------------------------
r9097 | SvenDowideit | 2006-03-06 07:22:06 +0100 (Mon, 06 Mar 2006) | 1 line

Item1789: force a group load when needed
------------------------------------------------------------------------

I don't know how this is related to the top bar (it doesn't make much sense to me) - but this is what my tracking came up with .. hope it's reproducible.

-- SP

  1. It is (still) not on develop, that is running r9056. So r9097 could be possible.
  2. The affected pages are: edit, preview, attach pages, viewprint, settings, rename, rename attachment (no oops pages).
  3. For the affected pages, the view template is always read (but TWiki shouldn't).

AC

These lines are the the culprit! Removing them solves the problem.

AC

ok, I've made a change to my fix. however, these lines are not ment to be in TWikiRelease04x00 - they are for future use.

I'm worried that forcing a load of the groups at an early stage affects template rendering, I would suspect this is only an indication of a real problem somewhere else.

svn:9158

SD

ItemTemplate
Summary SVN install renders non-included template defs - waiting for Sven
ReportedBy TWiki:Main.ArthurClemens
Codebase

SVN Range Fri, 03 Mar 2006 build 9056
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins 9158
TargetRelease major
Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2006-03-09 - SvenDowideit
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback