• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

TWiki::getOopsUrl() doesn't allow the $params->{params} argument to have null items in the list. Eg. the generated url can't have ?param1=;param2=foo

Change

        my $p;
-       while( $p = shift @$PARAMS ) { 
            push( @urlParams, "param$n" => $p );

to

        my $p;
+       while( defined($p = shift @$PARAMS) ) { 
            push( @urlParams, "param$n" => $p );

Correct. I did this by design, to trap the cases where required parameters to oops messages were being passed null strings.

Discarded (if you disagree with this decision, then please point out a case where a null parameter to an oops script is a required)

CC

ItemTemplate
Summary TWiki::getOopsUrl doesn't allow null url params
ReportedBy TWiki:Main.IanRogers
Codebase

SVN Range 4.0.x
AppliesTo Engine
Component

Priority Urgent
CurrentState No Action Required
WaitingFor

TargetRelease n/a
Edit | Attach | Watch | Print version | History: r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r4 - 2006-03-25 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback