• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Test case.

You have a form. Let us say that you have 4 fields.

And you have some topics that have used this form.

Now we redefine the two first fields in the form definition topic. We give them new names.

When you open a topic that contains the form you see the old form. That is how things have always been. That is OK.

Now we edit the topic. The topic form field are in the edit window the correct sequence.

When you save the form fields that are supposed to be the two at the top are now at the bottom screwing up the entire layout of the form.

To mend it you have to re-edit the topic, replace the form with the same form and save.

But normal users will never figure out this.

It is too late for 4.0.2 But should be fixed in 4.0.3 and therefore marked as patch.

KJL


The problem with this is that the only fix is to read the form topic on every view of a page that includes it. Major slowdown alert.

Perhaps in lieu of that, there could be scripts that could be cron'ed that would automate stuff like this.

ML

No. As long as you do not EDIT the page - the old form with old data remains.

When you edit the topic the form fields you have altered are put below the old unchanged fields. So it is when you edit and save that it goes wrong.

KJL


From my reading of the code, the form topic is not consulted unless you change the form (even to the same form). It's probably not that big a hit, but that's why things are out of order.

ML


The form topic must to some degree be consulted when you edit a topic because the fields have have changed value DO have the new values. These new values can only come from the form topic. But for some reason the no longer existing fields are removed and meta data of the new fields are appended instead of being put in the same order as defined in the form topic. So I do not believe this gives additional performance hit during edit and save. It is a logical error in the code.

KJL


This can be solved with a very low performance hit: Read the form definition on save, and make sure that the metadata is being saved in order.

RA


Actually, it is already read. All that is needed is to remove the existing field definitions frm the meta, and then allow them to be re-added from old values/thequery/the defaults in the def.

CC

Moved from Item2443:

As seen in TWiki:Plugins/HtmlMetaPlugin, the PackageForm has an TestedOnTWiki form field. It is defined as the second field in the form definition, and it shows up at as the second field in edit. But in view it shows up at the end, which is confusing. (Cairo re-arranged the form fields on each topic save based on the sequence defined in the form definition.)

-- PTh

Sorry, didn't notice this was reported against 4.0.2; this is fixed with this item.

-- SP

ItemTemplate
Summary Sequence of form fields in topics do not follow form definition
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.0.0, 4.0.1, 4.0.2, ~twiki4
SVN Range Mon, 27 Mar 2006 build 9563
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins 11161 11163 9715
TargetRelease patch
Edit | Attach | Watch | Print version | History: r15 < r14 < r13 < r12 < r11 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r15 - 2006-06-09 - SteffenPoulsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback