• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

This tag is commonly used in skins to render the breadcrumbs of a topic page. Unfortunately the implementation of this tag returns not only the parent but also the squared brackets to make it a twiki link. This is superfluous as the renderer does so on its own (given surrounding whitespaces).

So I'd propose that

%META{"parent" dontrecurse="on"}%
(dont mind dontrecurse="on") to return
ParentWeb.ParentTopic
instead of
[[ParentWeb.ParentTopic][ParentTopic]]

Here's the patch

--- lib/TWiki/Render.pm (revision 9851)
+++ lib/TWiki/Render.pm (working copy)
@@ -140,7 +140,7 @@
                  ( $pTopic eq $TWiki::cfg{HomeTopicName} ) ||
                  $visited{$parent} );
         $visited{$parent} = 1;
-        unshift( @stack, "[[$parent][$pTopic]]" );
+        unshift( @stack, $parent );
         last if $dontRecurse;
         $parent = $store->getTopicParent( $pWeb, $pTopic );
     }

This issue arose during TWiki:Support.HowToIncludeAllParentTopics.


SVN 9952, 9926 -- MD


This is a compatibility issue. The reason for the bracket link is so that non-WikiWord topics get linked properly, such as Singelton, Y2000Question, Topic_With-Dash-etc.

This should be enhamced with compatibility in mind, such as a format parameter.

-- PTh

I reverted the change since it broke parent display if the parent has a non-WikiWord name. Example:

Sandbox web > TestTopic1 > Sandbox.Foo-Bar > ChildTopic

Please enhance with a format="" parameter or the like.

-- PTh

Done. -- MD

Released 4.0.3

-- KJL

ItemTemplate
Summary Add format parameter to META{"parent"}
ReportedBy TWiki:Main.MichaelDaum
Codebase

SVN Range Wed, 12 Apr 2006 build 9798
AppliesTo Engine
Component

Priority Enhancement
CurrentState Closed
WaitingFor

Checkins 10003, 10004 10007 10008 10009 9925, 9926,
TargetRelease patch
Edit | Attach | Watch | Print version | History: r18 < r17 < r16 < r15 < r14 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r18 - 2006-06-28 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback