• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

There are several templates and topics in the default install where

  %SCRIPTURL%/script%SCRIPTSUFFIX%

is used instead of

  %SCRIPTURL{"script"}%

SCRIPTURLPATH is also not used consistently. This causes inconsistent overrides of paths when using $TWiki::cfg{ScriptUrlPaths}.

These are the files that I've found this in:

data/TWiki/SourceCode.txt
data/TWiki/SpreadSheetPlugin.txt
data/TWiki/TWikiClientApacheLoginDotPm.txt
data/TWiki/TWikiClientDotPm.txt
data/TWiki/TWikiClientTemplateLoginDotPm.txt
data/TWiki/TWikiHistory.txt
data/TWiki/TWikiPreferencesForm.txt 
data/TWiki/TWikiTip029.txt 
data/TWiki/TWikiTipsOfTheDayAddNew.txt 
data/TWiki/TWikiTipsOfTheDayAdmin.txt 
data/TWiki/TWikiTipsOfTheDayInclude.txt 
data/TWiki/TWikiTips.txt 
data/TWiki/WebAtomBase.txt 
data/TWiki/WysiwygPlugin.txt 
templates/edit.kupu.tmpl 
templates/login.classic.tmpl 
templates/login.tmpl 
templates/page.pattern.tmpl 
templates/twiki.classic.tmpl 
templates/twiki.tmpl 
templates/viewleftbar.pattern.tmpl 
templates/view.pattern.tmpl 
templates/view.plain.classic.tmpl 
templates/view.print.classic.tmpl
templates/view.print.tmpl 
templates/viewtopicactionbuttons.pattern.tmpl 

Thanks Diab. I knew about these. Unfortunately they are mostly in extensions which their authors have determined must be comaptible with Cairo. Since Cairo did not implement %SCRIPTURL{path}%, they have to use the %SCRIPTURL% form.

I think the ones in pattern skin can probably be fixed now; i strongly doubt if the current patternskin release works with Cairo anyway.

CC


Ok. I'm finding a lot of instances of this in various places (plugins & templates). If ShorterUrls are generated using Apache redirects, URl's generated by TWiki must not cause a redirect, or form data will be lost. The ability to use ScriptUrlPaths to rewrite the outgoing paths is a very nice addition. Just have to wait for everything else to catch up with it, I guess.

TWiki:Main.DiabJerius


You can always raise issues against the individual extensions that are causing the problem. This might prompt their authors to fix the problems.

Right now I'm marking this particular bug as being against pattern skin. This skin is pretty much TWiki-4 specific now, so ought to be fixable.

CC


Here is a patch to fix this bug on TWikiRelease04x00 branch revision 10470 : PatternSkin-r10470-fix_Item2156.diff

TWiki:Main.BenVoui


Thanks. I have commited the pattern skin changes.

AC


I have updated the remaining topics, except for ClassicSkin that should remain compatible with Cairo (?)

AC

ClassicSkin was shipped with Cairo. Why would anyone need to download a Classic skin for their Cairo??? It is not being developed for Cairo any longer. In fact it is not being developed for TWiki 4.X either. We just keep it alive. So I see no reason to keep this skin backward compatible. You can argue about plugins where bugs may be fixed which could also benefit Cairo users but I do not see this argument with ClassicSkin.

KJL


Alright, done. -- AC

4.1.0 released

KJL

ItemTemplate
Summary PatternSkin: SCRIPTURL{"script"} and SCRIPTURLPATH{"script"} are not implemented everywhere
ReportedBy TWiki:Main.DiabJerius
Codebase

SVN Range 4.0.2
AppliesTo Extension
Component PatternSkin
Priority Normal
CurrentState Closed
WaitingFor

Checkins 10480 10481 12180 12182
TargetRelease minor
Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatdiff PatternSkin-r10470-fix_Item2156.diff r1 manage 6.2 K 2006-06-05 - 12:58 BenVoui Patch to fix this bug on TWikiRelease04x00 r10470
Edit | Attach | Watch | Print version | History: r19 < r18 < r17 < r16 < r15 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r19 - 2007-01-16 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback