• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

In the Cairo release, a link like

[[Activity 1.2.3]]
rendered to
[[Activity123]]

In the Dakar release (applies to all 4.0.x versions), these links do not work anymore. Please see the URL linked from the question mark Activity 1.2.3

  • Link points to web rather than to a topic
  • Periods render to slashes

Might be linked to Bugs.Item2117


Argh.

No, it's not linked to Item 2117 The periods are being interpreted as web separators in a hierarchical web name. If you write [[Web.TopicName]], then it resolves to TopicName in Web.... if you write [[Web.1.TopicName]] it resolves to TopicName in Web/1. With hierarchical subwebs enabled, that is correct, I think. Trouble is, Cairo didn't have hierarchical subwebs.

The question is, how do we determine when to apply the "it's a hierarchical web spec" rule versus the "it's a topic name" rule. The obvious thing is to try to recognise valid web prefixes off the link text, before filtering printable characters, but that's very expensive. May be the only choice though.

Raising priority to Requirement.

CC

Made it recognise leading webs, but only if hierarchical webs are switched on. It will still behave like Cairo if it is off.

CC

This broke bracket links like [![Main.WebHome]]. Here's the fix

--- lib/TWiki/Render.pm (revision 10069)
+++ lib/TWiki/Render.pm (working copy)
@@ -732,8 +732,6 @@

         $web = join('.', @weba) if scalar(@weba);
         $topic = join('', @topica);
-    } else {
-        $topic =~ s/\.//g;
     }

     # Topic defaults to the current topic

Does the general issue need to be applied to DEVELOP too?

MD

Not that simple, I'm afraid. normalizeWebTopicName uses a regex that still matches multiple dots.

Fixed in TWiki4 and DEVELOP

CC

ItemTemplate
Summary Rendering of links containing periods does not work properly
ReportedBy TWiki:Main.ReneRembarz
Codebase 4.0.0, 4.0.1, 4.0.2, ~twiki4
SVN Range Mon, 24 Apr 2006 build 9906
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins 10069 10070 10071 10072
TargetRelease patch
Edit | Attach | Watch | Print version | History: r11 < r10 < r9 < r8 < r7 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r11 - 2006-05-04 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback