I don't know how long this has been failing, but it noticed it today before I started working on save script modifications to solve
Item252.
It is somewhat strange, as the save script does the right thing upto the call to
$store->saveTopic
. The form is
TestForm3
at this point. But somehow, after reading the saved topic the form is
TestForm1
which was what was there before the save.
(Note that the changes to
Item252 did not cause this defect.)
Is there something weird in your test environment? It passes fine in mine....
But I see an error in
test_templateTopicWithMeta
that
does appear to be a result of your changes
There was 1 failure:
1) /home/twiki/DEVELOP/test/unit/SaveScriptTests.pm:445 - test_templateTopicWithMeta(SaveScriptTests)
<undef> unexpected
(I updated the test to try and make it clearer, so svn up first)
CC
Hmmm. My tests give totally different results. Also, I don't see your update to the test script in SVN. Something is really out of synch here... I am attaching the
output of the test script. --
TW
Note further that line 446 in
SaveScriptTests
is the final closing brace of the test case. The error message does not quite make sense. --
TW
That last was my fault, I modified it to make the error clearer and didn't check it in; there now.
I do
not see an error on line 390. My code is almost identical to DEVELOP, though there is one minor change in Func but it should be irrelevant to this.
CC
I see your mods now to
SaveScriptTests
but still my result of running this unit test is as shown in
run1.log using a completely updated develop installation without any changes. --
TW
I still don't see the error, and from reading the test code I can't see how what you describe it ever possible. The topic in question is being written immediately beforehand, and
TestForm1 doesn't even enter the picture. Is it possible that you have an existing file sitting around blocking the tests? Is the topic file in question getting written? Note you can use:
print `cat $TWiki::cfg{dataDir}/$testweb/$testtopic.txt`;
to inspect the topic from the test. You can obviously
ls -l
it the same way.
CC
I'm going to have to discard this; the save script tests have changed a lot. Please re-open it if you still see the error.
CC
I cannot see how this test script could have worked for you. I have fixed the test script and checked it in as SVN 6231. Waiting for your approval, please close if ok. --
TW
It didn't - we just overlapped, confused eachother, and then independently fixed the bugs :-/
Thanks for the fix! All works for me, now.
CC