• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

See TWiki:Sandbox.IncludeTestParamIncl, which includes TWiki:Sandbox.TestParamIncl three times, once without a paramter, once with NAME="Jane", once with NAME="Jim" parameter. The included topic has these bullets - with behaviour:

  • is %IF{ "defined NAME" then="%NAME%" else="undefined" }% - bug : this returns always undefined. It should return the value of %NAME% if defined
  • is %IF{ "$ NAME='%NAME%'" then="%NAME%" else="undefined" }% - this always hits the then part (not sure if this is spec)
  • is %IF{ "$ NAME='Jane'" then="Jane" else="not Jane" }% - works as expected

Because of the first behaviour it is not possible to check for existence of a parameter. This prevents useful TWiki apps with parameterized includes, as discussed for example in TWiki:Plugins/EmbedPluginDev.

-- PTh

Test data from BugItem2880Test

%INCLUDE{"LitterTray.BugItem2880Test"}%

In Out
%IF{ "defined NAME" then="%NAME%" else="undefined" }% undefined
%IF{ "$ NAME='%NAME%'" then="%NAME%" else="undefined" }% %NAME%
%IF{ "$ NAME='Jane'" then="Jane" else="not Jane" }% not Jane

%INCLUDE{"LitterTray.BugItem2880Test" NAME="Jane"}%

In Out
%IF{ "defined NAME" then="%NAME%" else="undefined" }% Jane
%IF{ "$ NAME='%NAME%'" then="%NAME%" else="undefined" }% Jane
%IF{ "$ NAME='Jane'" then="Jane" else="not Jane" }% Jane

%INCLUDE{"LitterTray.BugItem2880Test" NAME="Doe"}%

In Out
%IF{ "defined NAME" then="%NAME%" else="undefined" }% Doe
%IF{ "$ NAME='%NAME%'" then="%NAME%" else="undefined" }% Doe
%IF{ "$ NAME='Jane'" then="Jane" else="not Jane" }% not Jane

Added unit test to Fn_IF that illustrates broken behaviour, and fixed it.

CC

Hi Peter I have added following to If.pm at line 129

        return 1 if( $twiki->{SESSION_TAGS}{ $eval } );

so my if defined sub will look as:

$defOps{defined} =
  { name => 'defined',
    prec => 5,
    type => 0, # unary
    exec => sub {
        my( $twiki, $a, $b ) = @_;
        my $eval =  $b->evaluate($twiki);
        return 0 unless $eval;
        return 1 if( $twiki->{SESSION_TAGS}{ $eval } );
        return 1 if( defined( $twiki->{cgiQuery}->param( $eval )));
        return 1 if( defined( $twiki->{prefs}->getPreferencesValue( $eval )));
        return 0;
    }
   };

I am not sure if I have done it the right way, but it works smile Please check it.

-- TWiki:Main.ThomasFreudenberg - 19 Sep 2006

Thanks Crawford for the super fast fix!

Thomas: This is the code change Crawford did:

Modified: twiki/branches/TWikiRelease04x00/lib/TWiki/If.pm
===================================================================
--- twiki/branches/TWikiRelease04x00/lib/TWiki/If.pm   2006-09-18 23:41:54 UTC (rev 11526)
+++ twiki/branches/TWikiRelease04x00/lib/TWiki/If.pm   2006-09-19 00:14:25 UTC (rev 11527)
@@ -128,6 +128,7 @@
         return 0 unless $eval;
         return 1 if( defined( $twiki->{cgiQuery}->param( $eval )));
         return 1 if( defined( $twiki->{prefs}->getPreferencesValue( $eval )));
+        return 1 if( defined( $twiki->{SESSION_TAGS}{$eval} ));
         return 0;
     }
    };

-- PTh

Hi together,

that's pretty cool, I mean its nearly the same fix I did, so I was not wrong, so I am happy smile . Just one question left for the patch of Crawford and that's why I guess my patch ist right.

If you include a page and use IF with some new created given params like %INCLUDE{ "bla" FOO="Jane" } and you will test it inside with %IF{"defined FOO"} then I guess it should be at first test the value from the additional params. This is needs following order for tests: SESSION_TAGS, cgiQuery and at last prefs.

What do you think about this ?

-- TWiki:Main.ThomasFreudenberg - 20 Sep 2006

Hi, sorry its me again. My last message is nonsense. It is not important in which order a defined param is tested. Sorry for silly question.

But working with that, a new wink question is left: Shouldn't it be possible to check if a param is given ONLY by param through INCLUDE. For example: Someone has Set a global Var insinde WebPreferences with name WIDTH. To make sure that I test only WIDTH given by Param insinde the INCLUDE area I have to make sure that the param Name is unique like %INCLUDE{ "MyTopic" MyTopic_WIDTH="bla" }. It could also be done if we would have a test like "defined" but only for the params given by SESSION_TAGS.

What do you think about a additional operator in If.pm for tests like:

  • %IF{ "has_param WIDTH" then=... else=... }

Wouldn't this be easier to handle, espacially when you use %INCLUDE's ? I am not sure, if "has_param" is the right name, maybe you have a better idea.

-- TWiki:Main.ThomasFreudenberg - 20 Sep 2006

That could be a useful enhancement, although by convention one can use use unique names less likely to clash with prefsrences settings. If inclined, create a change proposal in the Codev web at TWiki.org.

-- PTh

4.1.0 released

KJL

ItemTemplate
Summary IF cannot check for existence of INCLUDE parameter
ReportedBy TWiki:Main.PeterThoeny
Codebase 4.0.2
SVN Range TWiki-4.1, Mon, 18 Sep 2006, build 11511
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins 11526 11527
TargetRelease minor
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2007-01-16 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback