• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
As discovered in Item2884, there is a limitation with the plugins API: Using TWiki::Func::checkAccessPermission, a plugin cannot check for access permissions with supplied $text if access control is in meta data (new feature in Dakar). As a workaround, a plugin must supply an undef $text parameter (at the cost of performance.)

A proper fix is to add one more $meta parameter to the function, and to reflect that in the API documentation.

-- PTh


This was lost due to not having a Codebase field.

I agree with your analysis. it would be good if it could be added in such a way as to avoid breaking existing applications (this is the reason it wasn't added before).

Regrading to Normal, as lack of activity on this suggests it was never Urgent.

CC

Done. Proposed for patch 4.1.2

CC

Just did this

grep -rl checkAccessPermission * | grep -v .svn
data/TWiki/TWikiHistory.txt
data/TWiki/TWikiReleaseNotes04x00.txt
lib/TWiki.pm
lib/TWiki/Search.pm
lib/TWiki/UI.pm
lib/TWiki/UI/Manage.pm
lib/TWiki/Templates.pm
lib/TWiki/Store.pm
lib/TWiki/Access.pm
lib/TWiki/Func.pm
test/unit/AccessControlTests.pm
test/unit/FuncUsersTests.pm
test/unit/FuncTests.pm
tools/benchmark/benchmark.Beijing
tools/benchmark/benchmark.Athens
twikiplugins/InclTag/lib/TWiki/Tags/INCL.pm
twikiplugins/EditTablerowPlugin/lib/TWiki/Plugins/EditTablerowPlugin.pm
twikiplugins/KoalaSkin/bin/savemulti
twikiplugins/FuncUsersContrib/test/unit/FuncUsersContrib/FuncUsersContribSuite.pm
twikiplugins/PeerPlugin/lib/TWiki/Plugins/PeerPlugin.pm
twikiplugins/SearchToTablePlugin/lib/TWiki/Plugins/SearchToTablePlugin.pm
twikiplugins/EditTablePlugin/lib/TWiki/Plugins/EditTablePlugin/Core.pm
twikiplugins/EditHiddenTablePlugin/lib/TWiki/Plugins/EditHiddenTablePlugin/Edit.pm
twikiplugins/SearchEnginePluceneAddOn/bin/plucsearch
twikiplugins/SignaturePlugin/lib/TWiki/Plugins/SignaturePlugin/Signature.pm
twikiplugins/XmlQueryPlugin/lib/TWiki/Plugins/XmlQueryPlugin.pm
twikiplugins/RedDotPlugin/lib/TWiki/Plugins/RedDotPlugin.pm
twikiplugins/EditContrib/lib/TWiki/Contrib/EditContrib/Include40.pm
twikiplugins/EditContrib/lib/TWiki/Contrib/EditContrib/Include41.pm
twikiplugins/TigerSkinPlugin/lib/TWiki/Plugins/TigerSkinPlugin.pm
twikiplugins/TigerSkinPlugin/bin/createtopic
twikiplugins/JavaPasteAddOn/bin/uploadmultiple.pl
twikiplugins/SpellCheckAddOn/bin/view
twikiplugins/SpellCheckAddOn/bin/spellcheck
twikiplugins/ImageGalleryPlugin/lib/TWiki/Plugins/ImageGalleryPlugin/Core.pm
twikiplugins/FileListPlugin/lib/TWiki/Plugins/FileListPlugin.pm
twikiplugins/HideInEditModePlugin/lib/TWiki/Plugins/HideInEditModePlugin.pm
twikiplugins/SetVariableAddOn/bin/setvar
twikiplugins/InlineEditPlugin/lib/TWiki/Plugins/InlineEditPlugin.pm
twikiplugins/ExcelImportExportPlugin/lib/TWiki/Plugins/ExcelImportExportPlugin/Export.pm
twikiplugins/SeeSkin/bin/savemulti
twikiplugins/PollPlugin/bin/poll
twikiplugins/PublishContrib/lib/TWiki/Contrib/Publish.pm
twikiplugins/PhotoarchivePlugin/lib/TWiki/Plugins/PhotoarchivePlugin.pm
twikiplugins/HiddenTextPlugin/lib/TWiki/Plugins/HiddenTextPlugin.pm
twikiplugins/GlobalReplacePlugin/lib/TWiki/Plugins/GlobalReplacePlugin.pm
twikiplugins/VotePlugin/bin/vote
twikiplugins/ChecklistPlugin/lib/TWiki/Plugins/ChecklistPlugin.pm
twikiplugins/IfDefinedPlugin/lib/TWiki/Plugins/IfDefinedPlugin.pm
twikiplugins/ActionTrackerPlugin/lib/TWiki/Plugins/ActionTrackerPlugin/ActionSet.pm
twikiplugins/MailToTWikiAddOn/bin/mailtotwiki
twikiplugins/DBCachePlugin/lib/TWiki/Plugins/DBCachePlugin/Core.pm
twikiplugins/DBCachePlugin/lib/TWiki/Plugins/DBCachePlugin/WebDB.pm
twikiplugins/TWikiCacheAddOn/bin/view
twikiplugins/NatSkin/pub/TWiki/NatSkin/Cairo_UI_pm.diff
twikiplugins/CommentPlugin/lib/TWiki/Plugins/CommentPlugin/Comment.pm
twikiplugins/NatSkinPlugin/lib/TWiki/Plugins/NatSkinPlugin.pm
twikiplugins/NatSkinPlugin/lib/TWiki/Plugins/NatSkinPlugin/Search.pm
twikiplugins/BlackListPlugin/lib/TWiki/Plugins/BlackListPlugin.pm
twikiplugins/YetAnotherXpTrackerPlugin/lib/TWiki/Plugins/XpTrackerPlugin.pm
twikiplugins/WebDAVPlugin/tools/dav.pl
twikiplugins/WebPermissionsPlugin/lib/TWiki/Plugins/WebPermissionsPlugin.pm

So yes. It is for 4.1.2 and not 4.1.1. And the above list shows that we need to test at least some of these plugnis to ensure we did not create a problem. And maybe even change the plugins so that take advantage when feasible.

-- TWiki:Main.KennethLavrsen - 04 Feb 2007

The code fix is merged to Patch04x01 for inclusion in 4.1.2.

We still need to access if CommentPlugin and EditTablePlugin need to be updated or they are OK.

-- TWiki:Main.KennethLavrsen - 27 Feb 2007

They are OK. They both uses either a '' or undef as third parameter.

Adding meta data object when calling checkAccessPermission is up to new bug items to track. Waiting for release

-- TWiki:Main.KennethLavrsen - 27 Feb 2007

Closed with release of 4.1.2

KJL

Cleaned "WaitingFor" field.

-- TWiki:Main.GilmarSantosJr - 10 Aug 2008

ItemTemplate
Summary Meta data ignored by TWiki::Func::checkAccessPermission
ReportedBy TWiki:Main.PeterThoeny
Codebase

SVN Range TWiki-4.1, Sat, 23 Sep 2006, build 11571
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins 12746 12747 12979
TargetRelease patch
ReleasedIn 4.1.2
Edit | Attach | Watch | Print version | History: r14 < r13 < r12 < r11 < r10 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r14 - 2008-08-10 - GilmarSantosJr
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback