• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
A renderFormFieldForEditHandler has been added to the JSCalendarContrib that adds a dependency on EditTablePlugin, and is never called. It should be generalised or removed. The default date format documented for the JSCalendarContrib is never used by DateFiledPlugin or EditTablePlugin. frown

CC

Fixedin SVN, not released yet though.

CC


CC need to look at your changes, but the renderFormFieldForEditHandler is there for a reason. It supports calling JSCalendarContrib from Plugins. The dependency on EditTablePlugin is a mistake, but I am surprised that I left that in. --TW


Yes, please look at my changes. I took the handler out because
  1. It wasn't documented anywhere
  2. It wasn't called anywhere
  3. It duplicated the implementation in DateFieldPlugin
  4. It added a dependency on EditTablePlugin
We can either document that the handler in the DateFieldPlugin can be cross-called from other plugins, or we can move the handler out of the DateFieldPlugin and into the JSCalendarContrib.

CC


renderFormFieldForEditHandler is still being called from EditTablerowPlugin:
TWiki::Contrib::JSCalendarContrib::renderFormFieldForEditHandler(@_);
so now EditTablerowPlugin is broken. And that means BlogPlugin editing is broken as well.

The handler is also documented in the topic text.

So this is still left in a mess.

Can we decide on an action?

AC


Will handle. -- TW


Wasn't being handled, so I handled it. EditTablerowPlugin is still SNAFU, but this is the least of it's problems.

CC

ItemTemplate
Summary JSCalendarContrib is a bit of a mess
ReportedBy TWiki:Main.CrawfordCurrie
Codebase ~twiki4
SVN Range TWiki-4.1, Sun, 08 Oct 2006, build 11688
AppliesTo Extension
Component DateFieldPlugin, EditTablePlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:11704 TWikirev:13605
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r11 < r10 < r9 < r8 < r7 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r11 - 2007-05-02 - TWikiUserMapping_CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback