• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
When you use something like this in a plugin

TWiki::Func::saveAttachment($web, $topic, $fileName,
                            { file => $tempName,
                               filedate => $fileDate,
                               filesize => $fileSize,
                               filepath => $fileName,
                               comment => "Generated by !AttachContentPlugin"
                            });

Then you get this kind of garbage in the meta


Why do we get these useless parameters?

stream="GLOB(0xa421c98)" tmpFilename="/tmp/Z4IDRIcEXv"

This is found both on 4.0.4-4 and on MAIN

The quick testcase for this is to use the AttachContentPlugin and make a topic with this.

%STARTATTACH{"myfile.txt"}%
Some test text
And a little more
%ENDATTACH%

KJL

They happen to be lying around in Meta. They are cache parameters, same as most of the content of META:FILEATTACHMENT.

Perhaps a bit inelegant, but not a bug.

CC

Then let us call it an enhancement though still with low priority. Peter and I discussed this on IRC and we agreed that this garbage should not be in the META:FILEATTACHMENT. There should only be the parameters that are actually useful. And having a value saying GLOB(0xa421c98) is right out bad programming.

I spent hours trying to find out what I did wrong using TWiki::Func::saveAttachment and others will for sure have the same experience.

I am getting pretty annoyed about how quickly bug items are being discarded here without dialog, and I want that discussed at next release meeting. It is really annoying me and I know others are annoyed about it as well.

KJL

This is now fixed in trunk and 4.3 branch.

-- PeterThoeny - 2010-05-09

ItemTemplate
Summary TWiki::Func::saveAttachment saves a lot of garbage in META
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.0.4, 4.3.2, ~twiki4
SVN Range TWiki-4.1, Sun, 08 Oct 2006, build 11688
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:18623 TWikirev:18624
TargetRelease patch
ReleasedIn 5.0.0
Topic attachments
I Attachment History Action Size Date Who Comment
Texttxt myfile.txt r1 manage 0.1 K 2006-10-19 - 08:21 KennethLavrsen Generated by AttachContentPlugin
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2010-05-31 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback