• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Seems to me we have a problem - all the InitFormTests fail, with differences in the output html. is this because we're using different version of CGI? or different settings or what?

I'll commit the changes, and we cna take a peek later.. -- SD

First let me thank you for diligently looking at the test cases. However, now all these test cases fail on my machine. Obviously the HTML generated on our installations is subtly different...

I updated my CGI to the latest version on CPAN (3.25), but the tests are still failing. I am going to back out your updates.

Obviously it is not a good idea to have test cases that are sensitive to the HTML generated. So sorry... frown -- TW


From CC: You have to use $this->assert_html_equals and $this->assert_html_matches to compare HTML. CGI will generate random parameter orders in tags, which prevents string comparison from working.
I looked at these functions. They are surely strange, as in the cases I tried assert_html_equals returns false when comparing a string of HTML to itself. Also, the only test case that uses these functions is FormattingTests.pm and all these tests fail for me.

(The perl module HTMLDiffer which it uses, is from TWiki:Plugins.TestFixturePlugin. -- TW


Well, for some reason these functions work now (reasonably well) and I have replaced the use of tree walking by assert_html_matches. -- TW

ItemTemplate
Summary Make test/unit/InitFormTests more resilient to HTML changes
ReportedBy TWiki:Main.ThomasWeigert
Codebase ~twiki4
SVN Range TWiki-4.1, Thu, 09 Nov 2006, build 11947
AppliesTo Engine
Component BuildScripts
Priority Enhancement
CurrentState Closed
WaitingFor

Checkins 12444
TargetRelease minor
Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2007-01-16 - JasonHill
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback