• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

The unit tests in InitFormTests.pm can be made to pass by changing just one bit:

  • ALERT! No, that was a wrong path. -- haj, 02 Dec 2006

I would simply check that in, but it points to a case sensitivity in template names where there wasn't one before: The template in question is stored in a topic MyeditTemplate.txt, and I seem to recall that such a topic could be found by refering to 'myedit', as in the SVN version of the tests.

Could someone (TW?) please check whether this is an intentional change? If so, the test case can be fixed as written above.


After running some more tests it looks pretty clear that this is not intended, and the bug is in the code.

In r12038, (one of the commits of Item2907), two calls of ucfirst have been moved in lib/TWiki/Templates.pm. Unfortunately they have been moved into a conditional which only is executed if a template parameter has the syntax template=Web.Template, but not if it is just template=myedit (as in InitFormTests.pm and TemplateTests).

Since the bug is in Beta2 and Item2907 is marked "Waiting for Release" I'll no longer commit to that item, but use the current 3226 instead.


Fixed, and closed. It would be nice if TW could confirm my observations, or undo my patch if appropriate.

ItemTemplate
Summary Broken case sensitivity in templates (was: Unit test InitFormTests.pm fail)
ReportedBy TWiki:Main.HaraldJoerg
Codebase

SVN Range TWiki-4.1, Tue, 28 Nov 2006, build 12081
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins 12135
TargetRelease n/a
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r5 - 2006-12-02 - HaraldJoerg
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2024 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback