• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

As seen in Item2592 the use of "cmd" for a normal save within the same revision timeout period is confusing to the users.

The original idea of this was that the cmd was used when using the special ?cmd=something with edit and save.

But since the repRev function in Store.pm is used for the normal saving of a topic is makes sense to write "save" in the log instead of "cmd" in this case.

The extra information still says that it is a repRev (repeat revision) ie saving without uprevisioning the topic. So we do not loose this info.

Changing the logging to save means that an admin command with repRev will also say "save" but I think it is better that the log matches the normal 99.9999% use and still with the cmd=repRev we have the same information in the extra so we loose nothing and we confuse less.

I cannot see any unit test case affected and I am not bright enough to write one from scratch.

I will check this simple code change in.

KJL

As I was integrating a patch in Item3089 I read the code and see that my fix will make the statistics count repRev changes in the statistics. That is not what we want. So I will revert this change back and instead document the cmd action better.

KJL

Per discussion http://koala.ilog.fr/twikiirc/bin/irclogger_log/twiki?date=2006-12-08,Fri&sel=92#l88 we decided for now to keep my fix from yesterday

KJL

4.1.0 released

KJL

ItemTemplate
Summary Logging of saving a topic within the same revision timeout is confusing
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.0.5, ~twiki4
SVN Range TWiki-4.1, Tue, 28 Nov 2006, build 12081
AppliesTo Engine
Component

Priority Low
CurrentState Closed
WaitingFor

Checkins 12175
TargetRelease minor
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2007-01-16 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback