• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
hit edit on this topic, the HTML head contains

<base href="http://develop.twiki.org/~twiki4/cgi-bin/view/Bugs/Item3401"></base><!--/closing tag 'solves' IE selection bug-->

which is quite obviously wrong.

the worst thing is, that this wrong tag gets added into all skins - i'm not sure from what (i've not had time to look yet)

the defautl skin passes validation IF you run from svn, prior to doing a pseudo-install. after running pseusdo-install -link default this tag appears, and this there are failures

(also the </base> is invalid HTML frown ) (according to HTML:Lint)

SD

What is the failure?

The closing /base was added for a very good reason.

Without it you could not select text in IE.

KJL

the base close is just an additional whinge form the validation tool i'm using, the real issue is that the base url is always to the 'view' script, even in edit etc.

SD

I am re-opening this as urgent:

These changes might fail on sites that have scripts with an extension since %SCRIPTNAME% does include the extension and %SCRIPTURL{}% expects the script name without extension.

-- PTh

mmm, so we have SCRIPTSUFFIX, and SCRIPTNAME, but no way to get the the name without the suffix frown

-- SD

I am pretty sure that it is even worse to have the SCRIPTNAME, e.g. edit in the base tag. The base tag is there to complete relative urls in the body. For example a %TOC% generates relative urls to jump to the anchors. So imagine you added %TOC% to an edit screen. Then each anchor in the list will trigger a new edit on the current topic ... which you are already editing.

Same with any other scriptname. Ergo, the view action in the base tag was alright.

The base tag is currently set to

<base href="%SCRIPTURL%/%SCRIPTNAME%/%WEB%/%TOPIC%"></base>
which completely undermines the ScriptUrlPaths feature. But, as already stated above the following is also wrong
<base href="%SCRIPTURL{"%SCRIPTNAME%"}%/%WEB%/%TOPIC%"></base>
because %SCRIPTNAME% might contain a script extension ... which it shouldn't and is a bug in itself in TWiki::_SCRIPTNAME().

Sven, can you please explain why you want a base tag like, for example this:

<base href="/cgi-bin/twiki/edit/Main/WebHome"></base>

MD

Michael, I fear that like Kenneth, you missunderstand the reason i created this bug. When working on skins, I use an automated test tool to validate the output HTML (in this case HTML::Lint), and the tool indicated that a view based URL for an oops html was invalid.

its true that there are issues, but to continue with your example, base being the 'view' script would go to entrily the wrong place, if you used a %TOC% in an oopsmore template, or anywhere else, unless it matches where your browser currently is.

I'm not thrilled about this either, but I suspect that

<base href="%SCRIPTURL%/%SCRIPTNAME%/%WEB%/%TOPIC%"></base>
is the lesser of many evils frown

SD

Ah ok, I see now.

How about we use

<base href="%SCRIPTURL{"%SCRIPTNAME%"}%/%WEB%/%TOPIC%"></base>
and fix %SCRIPTNAME% not to contain the script suffix.

MD

yes, well, if we change %SCRIPTNAME% not to contain the script suffix, we'll be breaking alot of stuff frown even though i agree that its odd having a TWikiVariable for view.pl and for .pl but not one that tells you that you are in the view context.

all in all, considering the current functionality this bug is closed, and if someone wants to add a new feature for scriptcontext that'd be useful i think

-- SvenDowideit - 19 Feb 2007

Cleaned "WaitingFor" field.

-- TWiki:Main.GilmarSantosJr - 10 Aug 2008

ItemTemplate
Summary Base tag refers to topic view, irrespective of what the current base url actually is (RELOADED)
ReportedBy TWiki:Main.SvenDowideit
Codebase 4.1.0, ~twiki4
SVN Range TWiki-4.1.0, Thu, 04 Jan 2007, build 12435
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins 12482 12483 12484 12485 12486 12487 12499 12500 12501
TargetRelease minor
ReleasedIn 4.1.0
Edit | Attach | Watch | Print version | History: r28 < r27 < r26 < r25 < r24 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r28 - 2008-08-10 - GilmarSantosJr
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback