• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
Configure does not compare octal settings correctly and it presents the default value as decimal

Look at configure.

Find the settings for {RCS}{dirPermission} and {RCS}{filePermission}

There are two problems - maybe with same root cause.

Even if you never changed them there is always the small red delta and when you hold the mouse of it the default present is 493 and 420 (the first number is 509 in 4.1.0 because of a bug which has been fixed on SVN).

The formfield value is correctly 0755 and 0644.

493 and 420 are decimal values for 0755 and 0644 octal.

I have studied the code and tried to fix it.

The place I get stuck is in lib/TWiki/Configure/Value.pm in subroutine needsSaving. The function $this->getType()->equals($curval, $defval); is always returning false when it is an octal. I do not understand what this object code is trying to do. This is too advanced for me. And obviously too advanced for the one that wrote it because it does not work. wink (meant as fun remark)

I have not yet analysed why the presentation is in decimal.

I think Crawford needs to fix this one. I simply do not understand this object oriented design.

-- TWiki:Main/KennethLavrsen - 28 Jan 2007

After Item3529 was fixed half of this bug was fixed too. configure now compares default with actual correctly.

But when default is not equal actual the mouse over tooltip you see when you hoover over the delta symbol is still displayed in decimal.

When you save the data the changed settings are shown. And in case of an octal the value is shown decimal which may confuse a person to think he typed it wrong.


Agreed, but this is the tip of the iceberg w.r.t. presentation in configure. It is functionally correct, so i have to drop this to Low priority. Raise it again if you think that's unfair.

CC

ItemTemplate
Summary Configure does not present octal settings correctly
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.1.0, ~twiki4
SVN Range TWiki-4.1.0, Mon, 22 Jan 2007, build 12595
AppliesTo Engine
Component Configuration
Priority Low
CurrentState Confirmed
WaitingFor Someone to fix it
Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2007-04-13 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback