• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3547: Passthrough files not cleaned up if not stored in same directory as session files

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   patch 4.1.1

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Since Item3546 passthrough files are no longer stored in /tmp. This raises the spectre of two problems:
  1. configure will flag an error if the directory where passthrough files are stored does not exist, and /tmp/twiki does not normally exist. This is rather unclean.
  2. TWiki::Client::expireDeadSessions is overloaded to clean up old passthrrough files (which can be left behind when a client aborts a page load) but it only processes the {Sessions}{Dir} dir. As long as passthrough files were stored there this was ok, but now....

I'm OK with ignoring (1) for now, but passthrough files must be cleaned up.

-- TWiki:Main/CrawfordCurrie - 01 Feb 2007

In 4.1.0 and earlier I guess we had the same problem. If someone had not put the same directory for passthrough and session files the passthrough files would never be cleaned out.

Maybe we should just have ONE setting for temporary files?

I am currently looking at the passthrough thing in the code to see how they work and if they perhaps should just stay in /tmp

-- TWiki:Main.KennethLavrsen - 01 Feb 2007

At a meeting Monday 01 Feb 2007 in #twiki_security it was decided that

  • The $TWiki::cfg{Sessions}{Dir} and $TWiki::cfg{PassthroughDir} are replaced by a new $TWiki::cfg{TempfileDir} which defaults to /tmp/twiki
  • The code that create passthrough files must create the TempfileDir like it already happens for sessions in case sessions are disabled.

I have already coded it and will check it in

-- KennethLavrsen - 02 Feb 2007

Done. MAIN and Patch04x01

-- KennethLavrsen - 02 Feb 2007

ItemTemplate
Summary Passthrough files not cleaned up if not stored in same directory as session files
ReportedBy TWiki:Main.CrawfordCurrie
Codebase 4.1.0, ~twiki4
SVN Range TWiki-4.1.1, Tue, 30 Jan 2007, build 12650
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins 12712 12713
TargetRelease patch
ReleasedIn 4.1.1
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2007-02-25 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback