• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3557: TempfileDir checker is useless

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   patch 4.1.2

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The configure checker for TempfileDir is coded as follows:
    unless( -d $TWiki::cfg{TempfileDir}) {
        my $e2 = $this->checkTreePerms( $TWiki::cfg{TempfileDir}, 'rw' );
        $e .= $this->ERROR($e2) if $e2;
    }
This means the permissions will be checked only if the directory does not exist.

-- TWiki:Main/CrawfordCurrie - 04 Feb 2007

Recommend for inclusion in 4.1.1

CC

I will for sure not check in this change as it is.

Try and delete your LocalSite.cfg and delete /tmp/twiki

And then run configure turning your brain into newbie mode.

Yoy are now met with a an increased number of unnecessary errors.

Harald did a good job in getting rid of them so that the first time you run configure, you only see the warnings inside General Path Settings. Then you hit next and the normal situation will be a few warnings related to selecting login manager and admin email address.

And those you could have set in the first pass without any damage.

Now I get "Error: /tmp/twiki/ is not writable" which is not very useful.

The way it works on a normal Linux/Unix is the minute you start using TWiki it creates the /tmp/twiki for you. I added the creation of the directory to the passthrough update I did and CGI::Session already does the same. So for the normal installer there is no need for any error message. If we are to check for something then it is that /tmp is writable so that the twiki directory can be created.

{RCS}{WorkAreaDir} is another one that suddenly starts making noise again. Please remove that noise the first time you run configure until LocalSite.cfg is saved.

-- TWiki:Main.KennethLavrsen - 04 Feb 2007

Let's get this straight; configure is an admin interface, not an installer script.

Having said that I understand your point, but it should reflect on Item3559, not on this checker which is quite correct and is required.

Pushing back to KJL for a release decision.

CC

The release decision is that configure as it is today on Patch04x01 04 Feb 2007 SVN12761 is what gets released in 4.1.1 because today is release day and I want to go to bed at a normal hour

KJL

Okey doke. Well, in that case, I'll tag it as "Waiting for Release" for the next patch.

CC

I see only one SVN checin but it is saying waiting for release and patch.

Was this merged over to Patch04x01 after the 4.1.1 release?

-- TWiki:Main.KennethLavrsen - 08 Feb 2007

No.... well spotted, I'll do that. OK, done, setting back to WFR

CC

Closed with release of 4.1.2

KJL

ItemTemplate
Summary TempfileDir checker is useless
ReportedBy TWiki:Main.CrawfordCurrie
Codebase

SVN Range TWiki-4.1.1, Fri, 02 Feb 2007, build 12717
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins 12749 12808
TargetRelease patch
ReleasedIn 4.1.2
Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r10 - 2007-03-04 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback