• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3638: Edit link in actionnotify mail does not work in IE7

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension ActionTrackerPlugin Normal Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

At the office, everyone is now using IE7. I'm trying to use the actionnotify system, and it works fine, but when people click the 'edit' link in the notification mail, instead of:

http://wiki/bin/edit/Test/TestTopic?skin=action,pattern;atp_action=000075;t=1171555347

which is the link in the e-mail, the browser address is mangled to become

http://wiki/bin/edit/Test/TestTopic?skin=action

as a consequence, the topic is shown in raw mode instead of the editing of the action. When I copy/paste the link into the address bar of the browser, all works well. Unfortunately I cannot test this on IE6 anymore. Hope there's a solution.

-- TWiki:Main/JosMaccabiani - 15 Feb 2007

Unfortunately I can't test in IE7, so I'm unable to see this. However it would appear that IE7 is having problems with the comma. Comma is a special character in URLs, and should be URL encoded.

Please try this:

Take the action link you give above, and paste it into the browser link bar. Then edit the link and change the comma to %2C. Let me know if that cures the problem.

If it works, the code change necessary is this:

In Action.pm

# PRIVATE format edit field
sub _formatField_edit {
    my ( $this, $asHTML, $type, $newWindow ) = @_;

    if ( !$asHTML ) {
        # Can't edit from plain text
        return '';
    }

    my $skin = join( ',', ( 'action', TWiki::Func::getSkin()));

    my $url = TWiki::Func::getScriptUrl(
        $this->{web}, $this->{topic}, 'edit').
          '?skin='.$skin.';atp_action=' . $this->getAnchor() . ';t='.time();
Change this last bit to:
    my $url = TWiki::Func::getScriptUrl(
        $this->{web}, $this->{topic}, 'edit',  skin=>$skin, atp_action=>$this->getAnchor(), t=>time());

-- TWiki:Main.CrawfordCurrie - 18 Feb 2007

Update:

  • directly pasting the URL in IE7 address bar works, even with the comma
  • manually changing the comma to %2C works as well
  • clicking on the 'edit' link from the mail, using Thunderbird, does not work

Thanks for the quick patch! I'm a bit shy about notifying people too often, so I won't know if it works untill Thursday, but I'll let you know.

-- TWiki:Main.JosMaccabiani - 19 Feb 2007

Yes, the patch works great!

-- TWiki:Main.JosMaccabiani - 21 Feb 2007

Thanks for testing. Updated version uploaded.

CC

ItemTemplate
Summary Edit link in actionnotify mail does not work in IE7
ReportedBy TWiki:Main.JosMaccabiani
Codebase 4.1.1
SVN Range TWiki-4.1.1, Wed, 14 Feb 2007, build 12874
AppliesTo Extension
Component ActionTrackerPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins 12958
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2007-02-22 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback