• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3805: footerrows setting is ignored when adding rows

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension EditTablePlugin Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

If the table is defined as having footer row(s), EditTablePlugin should insert new rows before the footer rows when "Add rows" is invoked. Currently, "Add rows" appends the rows to the table.

Name Age
Name2 Age2
Mike 23
John 25
Name Age

-- TWiki:Main/DanDascalescu - 24 Mar 2007

in svn MAIN, I have commited code that actually renders the header as a HTML thead and the footer as a HTML tfot section - so it should be easier for EditTablePlugin to grab that, and insert its stuff into the tbody

-- TWiki:Main.SvenDowideit - 24 Mar 2007

It is a bug that a footer row is not respected when adding rows.

It is not an enhancement.

-- TWiki:Main.KennethLavrsen - 11 May 2007

I have very recently had to give up using this plugin in combination with having a line that contains %CALC because adding a row goofs up the whole thing.

This really needs to get resolved now. And I see I am not alone with this problem. Raising to urgent. We need to get this plugin a bit more stable.

KJL

The plugin parses tables in TML format, not rendered HTML. The solution should be in reading the TABLE attributes for headerrows and footerrows.

-- TWiki:Main.ArthurClemens - 17 Oct 2007

Below is a nice little test case from real life.

This table can be edited in Edit Table plugin but try to add a row and all goes bad. The plugin should really be aware of the footer rows defined by the TABLE tag. OR gets its own set of attributes so it knows.

With the new javascript "add row" the new row is added below the footer row. Confusing to the user.

You can move it up. But then you edit ONCE with TMCE in IE and TMCE eats a new line in front of EDITTABLE tag. When you then add a row using the javascript feature the table is destroyed. Yes another newline eating bug for Crawford. But this plugin should also be made robust to an edit table tag not being on its own line.

Project Customer Pass Type Purpose Qty Radios Controllers Hubs Tuners Hybrid Unit Cost (USD) Total Cost (USD) When (Q)
Total         6 22 5 6 10 1   34834  
Project X Engineering A PK2 Eng Test 2 4   2 2   6214 12428 Q1
Project X Factory A PC2 Fact Test 1 4   2 2   6214 6214 Q1
Project Y Eng P1 CT5 Eng Test 1 2 1     1 3502 3502 Q1
Project Y SW P1 CT5 SW Dev 2 4 2   2   6345 12690 Q1

-- TWiki:Main.KennethLavrsen - 18 Oct 2007

Thanks for the test example. One note: adding a row is not done by javascript.

-- TWiki:Main.ArthurClemens - 18 Oct 2007

I am quite far now with implementing this. Just need to fix some failing tests and a couple of new ones.

-- TWiki:Main.ArthurClemens - 29 Nov 2007

It works now. Unfortunately (low prio bug) TablePlugin does not handle more than 1 header row or footer row: Item5050.

-- TWiki:Main.ArthurClemens - 30 Nov 2007

Updating tests...

-- TWiki:Main.ArthurClemens - 03 Dec 2007

The error log gives warnings when no headerrows or footerrows is set.

-- TWiki:Main.ArthurClemens - 06 Dec 2007

ItemTemplate
Summary footerrows setting is ignored when adding rows
ReportedBy TWiki:Main.DanDascalescu
Codebase 4.2.0, ~twiki4
SVN Range TWiki-4.1.2, Fri, 23 Mar 2007, build 13217
AppliesTo Extension
Component EditTablePlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:15813 TWikirev:15814 TWikirev:15815 TWikirev:15816 TWikirev:15849 TWikirev:15850 TWikirev:15909 TWikirev:15910
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r22 < r21 < r20 < r19 < r18 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r22 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback