• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4320: Action Tracker Plugin Installer untar bug

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine Configure Normal New   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The installer has a bug in untar(). After calling tar with backticks, it checks the success with
  if ($!) ...
But $! is only set for calls to Perl system calls. It may have a true value at this point for no reason at all. The proper way to check the success of the external system call is:
  if ($?) { ... 
-- TWiki:Main/PeterScott - 29 Jun 2007

Oops, well spotted Peter! This isn't specific to the action tracker, it applies to all packages built using the BuildContrib. Not the first time I have done that; I appear to have $!/$? dyslexia frown

Priority raised to normal, and confirmed.

CC

Fixed. Future packages built using the BuildContrib will get it right.

CC

This bug just doesn't want to die... it is present in 4.3.1 in lib/TWiki/Configure/UIs/EXTEND.pm on lines 308, 310, 311, 345, and 346 and prevents the installation of, e.g. the ActionTracker via the web interface (even though tools/extender.pl appears to duplicate this code... but gets it right!)

ItemTemplate
Summary Action Tracker Plugin Installer untar bug
ReportedBy TWiki:Main.PeterScott
Codebase 4.1.2, 4.3.1
SVN Range TWiki-4.1.2, Thu, 28 Jun 2007, build 14298
AppliesTo Engine
Component Configure
Priority Normal
CurrentState New
WaitingFor

Checkins TWikirev:14311
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2009-05-13 - PeterScott
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback