• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4664: Web rename renames content as well

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine rename Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

When using the Rename tool from the WebPreferences topic to rename a web, the renaming itself works OK but it also renames content in the topics belonging to this web. I started with a web - let's call it Apple web - and renamed it to Fruit web. Now all occurrences of Apple in the topics of the Apple web were renamed to Fruit (and not only the links pointing to these topics).

-- TWiki:Main/MartinKaufmann - 18 Sep 2007

raising to urgent, so its on our radar for 4.2.0 (unless someone tests and can say its fixed) - we can lower it if we find its too much...

also see Item4661

If anyone wants to help - this is an areas taht obviously requires alot more unit tests

-- SvenDowideit - 19 Sep 2007

This applies to web renaming, which is not as well tested as topic renaming. Changed the headline from "Rename script renames content as well" to reflect this.

CC

I just manually tested this, and it looks OK. Martin, can you please give a specific setup where non-links are renamed, because it's working fine for me!

CC

I first tried the renaming in our main wiki and failed. I then set up a fresh TWiki4.1.2 install, created a new web with a few topics and tried the renaming there as well. Same result - it's renaming the whole content. I can send you screenshots and/or a tarred version of this web (or the whole wiki). Did you test it with the latest 4.2beta? I haven't tried that.

-- TWiki:Main.MartinKaufmann - 04 Oct 2007

Martin. The best is to attach the actual test web you used in a zip and describe exactly what you did incl what names you changed it to. Developers usually spend 80% of the time on reproducing the bug and 20% fixing it. Giving a clear test case makes bugs more likely to get fixed.

KJL

OK, here is a tar file of the web in question. It's called Apple Web and contains two topics called ApplePicking and PearPicking. Renaming the web (using the rename tool from the WebPreferences topic and leaving all change links to topics that refer to... ticked) from Apple to Fruit leads to the renaming of all occurrences of Apple in these two topics. Check for example the topic ApplePicking where the H1 title will have changed from Apple Picking to Fruit Picking and the subheading from An Apple Picking Schedule to An Fruit Picking Schedule.

For the test, I used an almost plain vanilla TWiki 4.1.2 installation.

-- TWiki:Main.MartinKaufmann - 05 Oct 2007

Thanks

I have tested your attached web. It does indeed fail in 4.1.2.

And good news. The problem seems fixed in 4.2.0.

I have tested your web and all renaming went perfect.

So upgrade to 4.2.0 when it gets released. Participate in the beta testing to help us getting it to a high quality.

Setting this as waiting for release.

-- TWiki:Main.KennethLavrsen - 06 Oct 2007

That's great news! Do you know whether it was fixed by accident by someone going over the code of UI/Manage.pm? I guess it must have been a bug in the regex somewhere. I might try to see whether I can include the changes in 4.1.2 as well. I don't think I'll be updating the system to 4.2 in the near future as it is quite a time-consuming process.

-- TWiki:Main.MartinKaufmann - 08 Oct 2007

ItemTemplate
Summary Web rename renames content as well
ReportedBy TWiki:Main.MartinKaufmann
Codebase 4.1.2
SVN Range TWiki-4.3.0, Tue, 18 Sep 2007, build 14939
AppliesTo Engine
Component rename
Priority Urgent
CurrentState Closed
WaitingFor

Checkins Fixed in some other unknown item
TargetRelease minor
ReleasedIn 4.2.0
Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatgz rename-web.tar.gz r1 manage 10.9 K 2007-10-05 - 22:06 MartinKaufmann tar file of Apple Web for renaming test
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback