• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4853: Does not support %EDITCELL

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension EditRowPlugin Urgent Closed TWiki:Main.FranzJosefGigler n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Does not support the %EDITCELL feature from EditTablePlugin

-- TWiki:Main/CrawfordCurrie - 18 Oct 2007

Does now.

CC

That's great to hear. Will test that as soon as possible.

-- TWiki:Main.FranzJosefGigler - 21 Oct 2007

Hm, tested it now on a TWiki 4.2 beta 2 installation. Getting multiple %EDITCELL entries when editing the following table wit EditRowPlugin.

Home: Client list List of Clients
Short: ABC * Short name of Client
Long: A Brandnew Company * Full name of Client
Note: This is a brandnew company producing ... Info about Client
Since: 2007-11-20 Client since
Page: http://abc.com Homepage
Phone: +1(0)xxx xxxxxx Phone number
    *...Mandatory

Will try it again on a beta 3 later.

-- TWiki:Main.FranzJosefGigler - 20 Nov 2007

Checked it on my (slow!) synology diskstation box running 4.2 beta 3 with the latest plugin version from twiki.org. Same problem! See for yourself at http://pfum.ath.cx/bin/view/Sandbox/BugsUserSandbox using BugsUser/pax as authentication pair. Edit and save the table twice and then look at the source. See the multiple EDITCELL entries?

-- TWiki:Main.FranzJosefGigler - 21 Nov 2007

Not good. Confirmed, and raised to Urgent.

CC

Fixed

CC

Hm, tested it on my beta 2 vmware debian box: doesn't multiply EDITCELL entries anymore okay, but doesn't save anything new in my test table at all anymore and that's NOT okay. Will test it on my beta 3 setup at home again later.

-- TWiki:Main.FranzJosefGigler - 23 Nov 2007

Sorry, it doesn't work. The cells get expanded, you can edit but if you want to save no chances are saved. See http://pfum.ath.cx/bin/rdiff/Sandbox/BugsUserSandbox?rev1=2;rev2=1

And there are these optical glitches (upper left corner should also contain an edit symbol (although the rows are labels and shouldn't be editable). It seems EditRowPlugin thinks there shall be a header but I don't want or need one. And in comparison to the EditTablePlugin the edit mode doesn't expand %COLOR% or other variables although they are used in label columns. But I guess that should be separate bug reports, right? wink

-- TWiki:Main.FranzJosefGigler - 23 Nov 2007

Thanks for testing, Franz.

It does work, but there's a constraint which doesn't exist with EditTablePlugin; columns marked as "label" or "row" cannot be overridden with an EDITCELL, as they are treated as read-only by the code. Since your example above specifies "label" type for all columns, the changes don't get saved. I had to balance the complexity of the code to deal with this special case, versus the utility of such columns. Given that this is likely to be a common special case, perhaps someone needs to invest in writing that code.

upper left corner should also contain an edit symbol - why? It's a header row, it's not editable. You specified headerrows=1, so you do want a header.

Expanding TWiki variables in read-only columns (such as labels) is a reasonable requirement. Yes, it should be a separate report.

CC

Thanks for clarfication. Brilliant as ever. Will find Found a workaround for the label issue. You're right about headerrows, my fault. EditTablePlugin is more forgiving in this case, but I guess that's actually less correct. wink

-- TWiki:Main.FranzJosefGigler - 25 Nov 2007

ItemTemplate
Summary Does not support %EDITCELL
ReportedBy TWiki:Main.CrawfordCurrie
Codebase 4.2.0
SVN Range TWiki-4.3.0, Fri, 12 Oct 2007, build 15261
AppliesTo Extension
Component EditRowPlugin
Priority Urgent
CurrentState Closed
WaitingFor TWiki:Main.FranzJosefGigler
Checkins TWikirev:15330 TWikirev:15332 TWikirev:15705 TWikirev:15736
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r16 < r15 < r14 < r13 < r12 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r16 - 2007-11-25 - FranzJosefGigler
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback