• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
In PersonalInfoAddOn: when using Change Picture and uploading a file, the filename was somehow set to %FILENAME% and then sanitised to FILENAME. I tracked the problem to use of view rather than attach on the Upload a New Picture link in PersonInfoPictureViewTemplate. I changed:
href="%SCRIPTURL{view}%/%BASEWEB%/%BASETOPIC%?template=PersonalInfoPictureUploadView">%MAKETEXT{"Upload a new one"}%</a></div><!--/piUploadNew-->%TMPL:END%
to
href="%SCRIPTURL{attach}%/%BASEWEB%/%BASETOPIC%?template=PersonalInfoPictureUploadView">%MAKETEXT{"Upload a new one"}%</a></div><!--/piUploadNew-->%TMPL:END%

but Attach.pm did not notice the template parameter. I made a trial fix, changing

        $tmpl = $session->templates->readTemplate( 'attachnew', $skin );
to
        $tmpl = $session->templates->readTemplate($query->param( 'template' ) ||  'attachnew', $skin );
It worked, but I't's not a complete fix and I don't know whether attach should honour template parameters.

And I'm sorry if I should have reported this elsewhere. Just let me know.

-- TWiki:Main/JohnMurphy - 14 Nov 2007

ItemTemplate
Summary PersonalInfoAddOn - change picture upload - filename is always REGISTER
ReportedBy TWiki:Main.JohnMurphy
Codebase 4.2.0
SVN Range

AppliesTo Extension
Component PersonalInfoAddOn
Priority Normal
CurrentState New
WaitingFor

Checkins

TargetRelease minor
ReleasedIn

Edit | Attach | Watch | Print version | History: r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r2 - 2007-11-16 - JohnMurphy
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback