• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5257: TinyMCE pads bullets incl. "set" variables with trailing spaces breaking some plugins and TWiki apps.

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension WysiwygPlugin Urgent Closed   patch 4.2.1, 5.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

TinyMCE plugin pads variables with trailing white space.
  • Set TESTPADDING = 123

Expand 555123 555 here

This seems to break some plugins and would break pages where variables are expected to expand without any white space.

Edit this page with the Raw editor, remove the trailing space from the 123. Then edit the page with wysiwyg, and make a minor change elsewhere on the page and save it. The string 555123555 becomes 555123 555.

minor edit

-- TWiki:Main/GeorgeClark - 17 Jan 2008

The actual cause is that Wysiwyg adds a space after any text in bullets. Not just settings.

Besides this bug we also have Item5190 and Item5259 and probably many others not yet reported because of this one.

Crawford. Is this space added as a way to avoid new-line eating or is it just a plain bug? I tried to see where in the code it is added. But it is not obvious to me.

As far as I can see editing and saving in TMCE adds a space to ALL bullets except the last one. Not the last one in a sequence of bullets. The last one in the topic does not get the space.

The first thing to consider is - strip off trailing spaces. But I know of at least ONE setting where the trailing space it intentional in a * Set statement so that is not a good idea either.

We have to step carefully if we fix this. We do not want an "eat newline" bug to re-appear.

-- TWiki:Main.KennethLavrsen - 17 Jan 2008

I'd be concerned about stripping spaces as well as adding them. We do a fair amount of dynamic content generation using variables, inserting text into tables, and other places where an extra space might change the layout or content. I think that in the case of set statements it's pretty critical that the user's literal input is not modified in any way.

I think I'd be more comfortable if the WYSIWYG editor wasn't the default editor on 4.2. At least with the 4.1 skins the user makes a fairly easy decision on whether or not to use the WYSIWYG. Now with "Raw Edit" hidden down on the bottom of the topic, users are going to be surprised, and I expect a lot of topic damage as users get used to the changes.

-- TWiki:Main.GeorgeClark - 18 Jan 2008

George: TWiki:Codev.TWikiRawEditDefault04x02

A link to this has also been added to the installation guide for 4.2.0.

If there is a large public demand for a real feature to swap this we may add it in 4.2.1 but not in 4.2.0. Too risky.

But the TWiki:Codev.TWikiRawEditDefault04x02 is a quick and easy hack.

-- TWiki:Main.KennethLavrsen - 18 Jan 2008

Goddam it, how many times have i fixed this bug? At least three. It is soooo hard to get right!

-- TWiki:Main.CrawfordCurrie - 21 Jan 2008

OK, fourth time lucky. I discovered TMCE was adding a space where it didn't used to add a space frown

CC

The merging from MAIN to T42 branch did not succeed. Something was missing. Another good reason why the developer and not I should do the merging.

Also updating the date on the change history. I will update t.o plugins also.

KJL

ItemTemplate
Summary TinyMCE pads bullets incl. "set" variables with trailing spaces breaking some plugins and TWiki apps.
ReportedBy TWiki:Main.GeorgeClark
Codebase 4.2.0
SVN Range TWiki-4.3.0, Tue, 15 Jan 2008, build 16238
AppliesTo Extension
Component WysiwygPlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:16285 TWikirev:16286 TWikirev:16290 TWikirev:16349 TWikirev:16350
TargetRelease patch
ReleasedIn 4.2.1, 5.0.0
Edit | Attach | Watch | Print version | History: r13 < r12 < r11 < r10 < r9 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r13 - 2008-08-04 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback