• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5387: Issue with multi-span rows and the EditRowPlugin / TablePlugin

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension TablePlugin Normal Closed   patch 4.2.1, 5.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The EditRowPlugin has trouble interpreting any multi-span directives in the first column, it handles multispan rows in any other column.

Example:

%EDITTABLE{ headerrows="1" format="| text, 40 | text, 15 | text, 25 | text, 25 | text, 25 |" }%
|*Decription*|*Part Number*|*WR server*|*Speedera*|*WR server*|
| Obi is super cute | tail | alameda | 1 | twiki.wrs.com|
|^| eyes | alameda | 1 |^|
| Birds are fabulous |^|sunnyvale|5|ala-engtools-dev|

-- TWiki:Main/PaulineCheung - 23 Feb 2008

Do you mean rowspan or column span? I don't see either type in the first row of your example....

CC

After an IM conversation with Pauline I understand the problem now. Confirmed.

OK, I understand the cause. The plugin adds an invisible HTML anchor to the first colum to allow table navigation, but the TablePlugin doesn't tolerate any other content in the marked cell. This means it is impossible to put an anchor (or any other invisible HTML) in a table row that consists only of rowspans. For that reason I'm passing this problem on to TablePlugin, which needs to apply the following trivial patch to allow ^ to coexist with HTML:

===================================================================
--- lib/TWiki/Plugins/TablePlugin/Core.pm    (revision 16418)
+++ lib/TWiki/Plugins/TablePlugin/Core.pm    (working copy)
@@ -616,7 +616,7 @@
             $attr->{width} = $columnWidths[$colCount];
         }
 
-        if (/^\s*\^\s*$/) {    # row span above
+        if (/^(\s|<[^>]*>)*\^(\s|<[^>]*>)*$/) {    # row span above
             $rowspan[$colCount]++;
             push @row, { text => $value, type => 'Y' };
         }

CC

Fixed in trunk and uploaded to TWiki.org. Will need to be merged to patch branch.

CC

Thanks for the bug fix.

A detail. Do not close until merged. There is no way we can find these unmerged bugs again once it is "below the fold".

I have merged now.

KJL

ItemTemplate
Summary Issue with multi-span rows and the EditRowPlugin / TablePlugin
ReportedBy TWiki:Main.PaulineCheung
Codebase 4.0.5
SVN Range TWiki-5.0.0, Wed, 23 Jan 2008, build 16283
AppliesTo Extension
Component TablePlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:16549 TWikirev:16552
TargetRelease patch
ReleasedIn 4.2.1, 5.0.0
Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2008-08-04 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback