• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5393: Adding bullet right after a heading adds annoying html paragraph tags

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine TinyMCEPlugin Urgent Closed   patch  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Adding bullet right after a heading adds annoying html paragraph tags

To reproduce (which I do now)

First we create some heading

  • Then I hit ENTER which creates a new line below the heading. I now hit the bullet tool in the TMCE tool bar.

  • I can edit an additional bullet by hitting enter. Each bullet - 1 or more - each get enclosed in html paragraph tags making a far to large line space

Making new heading

Then making a line which can be empty or with text

  • Hit ENTER and hit the bullet tool
  • I now get bullets without paragraph marks.

This is very very annoying.

-- TWiki:Main/KennethLavrsen - 25 Feb 2008

During the last release meeting the question was asked if this was only in IE6. I have now tested and the problem is both in IE6 and IE7

It does not happen in FF.

When you edit in IE everything appears correct when you edit. The paragraph markes are not visible until you save and you see the bullets having an all two large line distance.

-- TWiki:Main.KennethLavrsen - 07 Mar 2008

Can you reproduce the problem with "raw" tinymce on the moxicode website? I don't see a problem with firefox, and don't have access to IE right now, but I strongly suspect this is a tinymce or browser bug that needs to be reported upstream.

-- CrawfordCurrie - 07 Mar 2008

I do not see any paragraph marks added with neither IE or FF on the Moxicode website. Perhaps it is a TMCE bug which has been fixed and that we have not synced up to yet?

-- TWiki:Main.KennethLavrsen - 07 Mar 2008

Possibly. I will have to try and reproduce it myself for further analysis. But is this really Urgent? I am unlikely to be able to fix it for some time, I'm afraid.

-- CrawfordCurrie - 07 Mar 2008

I am personally annoyed by this 2-3 times per day.

I get this problem every time I write a topic with a head line followed by bullets. I think I write topics with headlines and bullet more often than I write any other type of topic. And each time I end up having to raw edit all those paragraph tags away. I may as well not use Wysiwyg then.

And looking at all the other topics people create I can see that I am not alone. We have these bullets with double line space everywhere.

It is so common in a business environment to make topics with lists of things to do or list of features or lists of bugs. Meeting minutes are always in the format headline for each agenda point and bullets points describing the decisions.

At the last release meeting we discussed if we should simply just let the Wysiwyg plugin remove paragraph marks if they surround the entire text in a bullet. That could be a short term work around.

-- TWiki:Main.KennethLavrsen - 07 Mar 2008

Can you clarify what you mean? do you mean that an LI enclosed in P tags should result in the P being removed? Sounds reasonable, but what about if the P has attributes set? Ideally I want you to tell me what simple transformation to the DOM tree will make this work for you....

-- CrawfordCurrie - 27 Mar 2008

What we talked about was a temporary work around which very rudely removed the leading and trailing paragraph tag round the text of a bullet.

It should only be removed in the simple case where the text after the LI tag begins with a <p> and ends with a </p> with no paragraph tags in the middle of the text. People are not very likely to put simple naked paragraph marks round the entire text of a bullet.

It would be a rude hack. Better would be to fix the TMCE. And it seems the newer TMCE does not do this (judging from the Moxicode site demo). But until we have time to integrate a new TMCE the rude hack would help many and harm very very few (I hope and assume).

examples

   * <p>Some bullet</p>
   * <p>Some other bullet</p>

should be saved as

   * Some bullet
   * Some other bullet

but

   * <p>Some</p><p>bullet</p>
   * <p>Some other</p><p>bullet</p>

should not be altered (hacked) when saved because the P is not a single one that starts and ends the bullet and therefore more likely to be intentional.

Any P with attributes should not be removed either for the same reason.

When the TMCE screws this up it always surrounds the entire text with paragraph tags with lower case "p" and no attributes.

-- TWiki:Main.KennethLavrsen - 28 Mar 2008

Here's a heading 3

  • hit the buttie tool, type text, hit return
  • looks OK to me

Here's another heading 3

  • type some text, then hit the buttie tool
  • now after a return, still OK.

Try again on IE:

Here's a heading 3

  • buttie tool, type text, good so far

  • another buttie, still fine

Here's another heading 3

  • type some text, then hit buttie
  • hit return, more jam, still fine.

Conclusion: I see the symptoms, above, but I cannot reproduce this on FF 2.0.0.3 or IE 7.0.5730 by following the instructions given above. I need detailed instructions how to reproduce this problem, please. The precise sequence of key clicks may matter.

One last try

  • Nope, that worked fine as well

-- CrawfordCurrie - 31 Mar 2008

You didn't have it for FF, but with IE you have. Take a good look after your first heading. I am using the same IE and have alwys this problem.

  • goto sandbox and create new auto topic
  • click in textfield
  • change heading to 3
  • type some text and press enter
  • type some new text
  • click the bullet icon
  • press enter to go to the new line
  • type some text
  • goto the save button

The result has those tags

-- TWiki:Main.FrederikBeun - 01 Apr 2008

Why is this waiting for me now??

This is a nobrainer to reproduce. Even Crawfords last editing shows the problem. There are paragraph marks round the bullets you added under "Try again on IE", Crawford!

-- TWiki:Main.KennethLavrsen - 01 Apr 2008

OK, I was able to reproduce it following Frederick's instructions. Fixed.

-- TWiki:Main.CrawfordCurrie - 12 Apr 2008

ItemTemplate
Summary Adding bullet right after a heading adds annoying html paragraph tags
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.2.0, ~twiki4
SVN Range TWiki-5.0.0, Wed, 23 Jan 2008, build 16283
AppliesTo Engine
Component TinyMCEPlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:16652 TWikirev:16653
TargetRelease patch
ReleasedIn

Edit | Attach | Watch | Print version | History: r15 < r14 < r13 < r12 < r11 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r15 - 2008-08-04 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback