• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5464: ALLOWTOPICRENAME should not apply to attachments

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal New   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Situation: User is not a member of TWikiAdminGroup

Page has

  Set ALLOWTOPICRENAME = TWikiAdminGroup

User attempts to delete an attachment on the topic.

Error:
Access rename not allowed on topic

This violates the Principle of Least Surprise. Deleting an attachment should fall under ALLOWTOPICCHANGE. The topic is not being renamed in this case.

Note that adding or "managing" an attachment falls under TOPICCHANGE as expected.

-- TWiki:Main/VickiBrown - 22 Mar 2008

Possible enhancement: ALLOWATTACHMENT* options might be interesting

-- TWiki:Main/VickiBrown - 23 Mar 2008

I think your original proposal is best and I agree that it is a bug that ALLOWTOPICRENAME affects renaming an attachment.

I do not think we need more complex access rights. The most reasonable fix would be to let ALLOWTOPICCHANGE be what limits renaming of attachments and only let ALLOWTOPICRENAME control renaming the topic name.

-- TWiki:Main.KennethLavrsen - 23 Mar 2008

Kenneth - agreed. Just an idea on the additional "Attachment" rights. My primary concern is that adding (or deleting or updating) an attachment should all fall under TOPICCHANGE.

-- TWiki:Main.VickiBrown - 25 Mar 2008

ItemTemplate
Summary ALLOWTOPICRENAME should not apply to attachments
ReportedBy TWiki:Main.VickiBrown
Codebase 4.0.5, 4.1.2
SVN Range TWiki-5.0.0, Sun, 09 Mar 2008, build 16496
AppliesTo Engine
Component

Priority Normal
CurrentState New
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r3 - 2008-03-25 - VickiBrown
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback