• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5489: Tables can no longer be rendered in text area form fields

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Confirmed   major  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Tables can no longer be rendered in text area form fields

This did not work in Cairo either but actually worked in 4.1

In 4.2 it is broken again.

4.1: http://merlin.lavrsen.dk/twiki41/bin/view/Motion/ConfigOptionAutoBrightness

4.2: http://merlin.lavrsen.dk/twiki42/bin/view/Motion/ConfigOptionAutoBrightness

Note that formfield works but in the form itself the table is shown as raw text.

I checked the two topics and they are identical so it saves OK. It is the rendering that goes wrong.

-- TWiki:Main/KennethLavrsen - 31 Mar 2008

Note: Item1133 is related but not the same bug.

This one is a bug because this was made to work in 4.1 and then broke again. So one would think it is possible to fix. I do not expect the ETP and TP to work in textarea fields but simple tables should be rendered as tables like in my example does in 4.1

-- TWiki:Main.KennethLavrsen - 31 Mar 2008

This is a bug taht needs to be fixed, but I do not consider it a release blocker for 4.2.1. Normal priority recommend.

-- TWiki:Main.PeterThoeny - 01 Apr 2008

Formfield values are protected from further rendering because otherwise it's easy to include TWiki syntax (and even HTML) in form values that breaks the enclosing table, and even the topic.

The solution may be to explicitly run the formfield value through TWiki rendering before protecting it. See TWiki::Form::FieldDefinition::renderForDisplay e.g. by inserting the line: $value = $this->{session}->renderer->getRenderedVersion($value);

Confirmed. However I'm not convinced it is possible to fix, as it is a cross-scripting issue to allow a formfield value to include embedded HTML.

-- CC - 01 May 2008

Thanks for the analysis

If this is not a nobrainer regex fix then we lower this to normal. I do not want to risk injecting a new bug or maybe even a new security issue on a rush fix for 4.2.1.

-- KJL - 01 May 2008

ItemTemplate
Summary Tables can no longer be rendered in text area form fields
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.2.0
SVN Range TWiki-5.0.0, Sun, 09 Mar 2008, build 16496
AppliesTo Engine
Component

Priority Normal
CurrentState Confirmed
WaitingFor

Checkins

TargetRelease major
ReleasedIn

Edit | Attach | Watch | Print version | History: r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r4 - 2008-05-01 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback