• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5612: Selecting "All Public Webs" option not sticking in UI

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   patch 4.2.1, 5.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

If you select the "All Public Web" checkbox, it is not checked when results are displayed. The conditional in the checkbox looked for "web" URLPARAM to be "all" but there was no value set for the checkbox so the web URLPARAM was returned as "on". At first I thought the fix would be to add value="all" to the checkbox definition. However, I found that it worked just as well to have the conditional look for the web URLPARAM to be "on". Apparently, in the search having web=on is equivalent to web=all.

In any case, there's the corrected element definition that works:

<input type="checkbox" class="twikiCheckbox" id="web" name="web" %IF{" '%URLPARAM{web}%' = 'on'" then="checked=\"checked\"" else=""}% />

If no one has any further feedback, I'll commit this change tomorrow.

-- TWiki:Main/LynnwoodBrown - 08 May 2008

Following the convention used in the other "Search where" form elements, I added the missing value declaration (value="all") rather than changing the value of URLPARAM that's checked as mentioned above.

-- TWiki:Main/LynnwoodBrown - 02 Jun 2008

This was not checked into the TWikiRelease04x02 branch but it is still marked as fixed in 4.2.1????

Reopening

-- KennethLavrsen - 02 Jun 2008

Fixed

-- TWiki:Main.KennethLavrsen - 02 Jun 2008

Thanks for fixing that, Kenneth. I need to review the management of the branches.

-- TWiki:Main.LynnwoodBrown - 04 Jun 2008

ItemTemplate
Summary Selecting "All Public Webs" option not sticking in UI
ReportedBy TWiki:Main.LynnwoodBrown
Codebase 4.2.1, ~twiki4
SVN Range TWiki-5.0.0, Sun, 04 May 2008, build 16770
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:16870 TWikirev:16874
TargetRelease patch
ReleasedIn 4.2.1, 5.0.0
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2008-08-04 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback