• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6000: changes tracked by loginname not wikiname

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal New TWiki:Main.AntonPiatek major  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

I have just upgraded from 4.2.1 (i think) to TWiki-4.2.3, Wed, 06 Aug 2008, build 17396

My twiki is set up to use apache logins (all connections are restricted to valid user in .htaccess) and users should register before editing pages.

Registered users seem to be tracked ok, at least it prints my name in the top left and my signature has my wikiname, however edits on the page are showing up with a derivation of my loginname (email address with html escaped entities) e.g. Main.anton40piatek_2eco_2euk

This seems to be only on the top/bottom of pages, as the list of changed pages shows wikinames next to them.

This used to work in 4.2.0/4.2.1

-- TWiki:Main/AntonPiatek - 17 Sep 2008

Thinking back, this used to behave differently - As an unregistered user it used to think I was "antonpiatekcouk" as it stripped the @ and.'s our of my loginid (they were removed from the allowed login regex in the config). Now it seems to be trying to convert them...

-- TWiki:Main.AntonPiatek - 17 Sep 2008

Registering a new user works the same as above - The user is recognised and greeted by their wikiname, but edits are stored in the page as their email address with @ replaced with _40 and . replaced with _2e Is this related to Item4771 which seemed to put in a fix to make this situation work better? (though I had it working before somehow, but I am using the RequireRegistration plugin to make sure all users were recognised)

-- TWiki:Main.AntonPiatek - 17 Sep 2008

There was a bug in 4.2.0 related to the translation of login names with non A-Za-z0-9 chars.

This caused both problems and was a security risk (different logins could be translated to the same Wikiname)

We had to fix this. And for those that had installed 4.2.0 and registered users this causes a small problem. But we had no choice. We had to fix the problem.

The behavior you have now is the same as Cairo, 4.0, 4.1 etc with respect to how unregistered users are shown.

For those that are registered with the strange logins you will have to hack the files if it hurts too much.

You probably upgraded from 4.2.0 and not 4.2.1 because nothing changed after 4.2.1.

I am no actioning this because we know the problem but cannot do anything about it without re-introducing the problem in 4.2.0.

-- TWiki:Main.KennethLavrsen - 18 Sep 2008

The list of changed pages shows peoples wiki names though - Is it possible to change the view template perhaps to lookup the loginname and convert it to wikiname?

-- TWiki:Main.AntonPiatek - 18 Sep 2008

It should be the same thing. The login name is converted to a Canonical ID which again is converted to a Wikiname based on the TWikiUsers topic. And depending on the login ID some may be translated right and some may not depending on what special characters were in the login ID.

-- TWiki:Main.KennethLavrsen - 18 Sep 2008

You are on to something - If I change my loginID to be the converted ID that is printed at the top/bottom of a changed page then it shows up as me who edited the page, however now the sidebar says "hello antonpiatek.com" (the @ has been dropped, not escaped and the .'s are left as is) Why is the sidebar doing a different resolution to the view template? The macro generated list of changed pages now also shows the pages I edited as being edited by Main.antonpiatek.com The wiki does not know who I am, because I am redirected to the register page by the RequireRegistration plugin. I think the view template is doing a wrong lookup, or saving the wrong ID - The rest of the wiki manages to find me fine with my normal email address as my loginid - just the ID written to the header of the pages seems to be different

-- TWiki:Main.AntonPiatek - 19 Sep 2008

If I edit the raw .txt of a page and change the last edit tag at the top to my email address (unescaped) then the top of the page shows my wikiname as the editor, but the recent changes page shows my email address with @ stripped. This really sounds like the view template is not converting the UID correctly - perhaps it needs to find the user by loginid instead of UID? Can you point me to the code to play with? I am still trying to learn about the internals of TWiki...

-- TWiki:Main.AntonPiatek - 19 Sep 2008

Can you give some examples of exact login names and some topics that show the problem.

Reopening. But normal priority.

-- KennethLavrsen - 23 Sep 2008

I log in with "anton@piatek.co.uk", this is stored in the TWikiUsers page I edit a page in the sandbox, and the top of the page shows the edit was done by Main.anton_40piatek_2eco_2euk The sandbox WebChanges page however shows the edit was done by AntonPiatek (my wikiname). The raw .txt of the edited topic has the following line

The same happens for every topic. The WebChanges shows correct wikinames, the sidebar shows my personal WebLeftBar page, greets me with my name etc. It is only the header/footer of a topic that shows my escaped email address (The edit history also shows the escaped email address) I can set up a copy of the wiki to hack some code if you have any suggestions - Unfortunately it is behind a firewall so I cannot give you a url to the pages

-- TWiki:Main.AntonPiatek - 23 Sep 2008

I log in with "anton@piatek.co.uk", this is stored in the TWikiUsers page.
I edit a page in the sandbox, and the top of the page shows the edit was done by Main.anton_40piatek_2eco_2euk The sandbox WebChanges page however shows the edit was done by AntonPiatek (my wikiname). The raw .txt of the edited topic has the following line

%META:TOPICINFO{author="anton_40piatek_2eco_2euk" date="1222156596" format="1.1" version="1.6"}%

The same happens for every topic. The WebChanges shows correct wikinames, the sidebar shows my personal WebLeftBar page, greets me with my name etc. It is only the header/footer of a topic that shows my escaped email address (The edit history also shows the escaped email address) I can set up a copy of the wiki to hack some code if you have any suggestions - Unfortunately it is behind a firewall so I cannot give you a url to the pages

-- TWiki:Main.AntonPiatek - 23 Sep 2008

Please check the fix of http://develop.twiki.org/~twiki4/cgi-bin/view/Bugs/Item6275 , that should fix this issue.

-- TWiki:Main.SopanShewale - 13 Jul 2009

ItemTemplate
Summary changes tracked by loginname not wikiname
ReportedBy TWiki:Main.AntonPiatek
Codebase ~twiki4
SVN Range TWiki-4.2.3, Wed, 06 Aug 2008, build 17396
AppliesTo Engine
Component

Priority Normal
CurrentState New
WaitingFor TWiki:Main.AntonPiatek
Checkins

TargetRelease major
ReleasedIn

Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r10 - 2009-07-13 - SopanShewale
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback