• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6109: What happened to TWiki::User?

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine SignaturePlugin Normal New   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Not clear to me how I should talk about this issue. Apologies if a bug report is the wrong way.

Running: TWiki-4.2.2, Wed, 06 Aug 2008, build 17396, Plugin API version 1.2

I just tried to install SignaturePlugin. It installs fine, but the plugin code fails. This happens because the plugin expects the user field of the session object to be a TWiki::User object. In fact, that field contains the user name.

Apparently TWiki was refactored to eliminate TWiki::User in 4.2. Hard to understand why such a major change in the API was made for a dot release.

This issue has already been noted in SignaturePluginDev. However, the original developer appears to be inactive. I could probably hack the plugin to accomodate the removal of User. But I'm not familiar with TWiki APIs, and bringing myself up to speed would require more time than I'll have to spare in the forseeable future.

Any hope of a backward compatability patch to support old plugins that need TWiki::User to exist? I suspect that there are a lot of valuable plugins that are broken because of its absence.

-- TWiki:Main/IsaacRabinovitch - 27 Oct 2008

Pointing back to TWiki:Plugins.SignaturePluginDev for further discussion and closing this bug.

-- OliverKrueger - 27 Oct 2008

I must respectfully disagree with your response to this issue. This is not about SignaturePlugin per se. As I said, several plugins seem to be affected. Anyway, I seem to have lost edit permission on SignaturePluginDev, so I have to respond here.

I call your attention to the TWiki::User API doc. It does not make it very clear that this object is part of the internal API and should not be used in plugins. The predictable result was that it was used in a lot of plugins that are now broken. This is a serious bug that needs to be addressed.

One option might be to bring back the object as a contrib. I'd volunteer to do that if it didn't involve too much work.

-- TWiki:Main.IsaacRabinovitch - 28 Oct 2008

I lost write permissions as well due to TWiki:Main.PeterThoenys actions. (Most likely I wont get them back, because I strongly disagree with Peter and joined the fork (as almost all active core developers did). See http://foswiki.org for further details.

Concerning the API: Func is the only official API since years now (afaik since Cairo). Most of the "voilations" to that fact are made by experienced contributors who should have known better. wink

-- TWiki:Main.OliverKrueger - 28 Oct 2008

Sigh. I wish you and the other participants in foswiki well. I have my own issues with the way Peter runs this project. However, it's not practical for me to base my own work on a new fork, so I have to stick with TWiki for now.

-- TWiki:Main.IsaacRabinovitch - 28 Oct 2008

You can use TWiki, you can use the other one or you can simply use both. I have no idea what future brings. But TWiki will have a hard time now after 95% of the developers have left.

-- TWiki:Main.OliverKrueger - 28 Oct 2008

Oliver paints a very black picture (in his own self interest). In reality we have over 600 people who agree to the new code of conduct and 30 who don't.

Isaac, you can conditionally code the plugin to support more than one TWiki version. TWiki:Codev/HandlingCairoDakarPluginDifferences has (somewhat outdated) info on how to do that.

-- TWiki:Main.PeterThoeny - 22 Nov 2008

 /* no comment */ 

-- TWiki:Main.OliverKrueger - 23 Nov 2008

600 people and only 1 who commits (sorry, 2 with Peter).

Once again Peter, maybe one day you'll learn the difference between ignorance and refusal.

Yes, you may remove my comment as it has nothing to do with this bug.

-- TWiki:Main.OlivierRaginel - 23 Nov 2008

ItemTemplate
Summary What happened to TWiki::User?
ReportedBy TWiki:Main.IsaacRabinovitch
Codebase 4.2.2
SVN Range TWiki-5.0.0, Wed, 22 Oct 2008, build 17677
AppliesTo Engine
Component SignaturePlugin
Priority Normal
CurrentState New
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2008-11-23 - OlivierRaginel
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback