• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6220: TwistyPlugin: Twisty can't be placed in TWiki table cells

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension TwistyPlugin Normal Closed   patch 4.3.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

A twisty in a TWiki table cell destroys the table because the plugin introduces newlines.

Test case:

|*Heading 1*|*Heading 2*|*Heading 3*|
| Text | Text |%TWISTY{}%my twisty content%ENDTWISTY%|
renders as:
Heading 1 Heading 2 Heading 3
Text Text More... Close my twisty content

As of today there is a newline between two spans if you look at the raw HTML of this page:

<span class="twistyPlugin twikiMakeVisibleInline">
 <span id="twistyIdItem62201show" ...

-- TWiki:Main/PeterThoeny - 24 Mar 2009

Fix:

Index: lib/TWiki/Plugins/TwistyPlugin.pm
===================================================================
--- lib/TWiki/Plugins/TwistyPlugin.pm   (revision 17851)
+++ lib/TWiki/Plugins/TwistyPlugin.pm   (working copy)
@@ -410,7 +410,7 @@
 
 sub _wrapInButtonHtml {
     my ( $text, $mode ) = @_;
-    return _wrapInContainerHideIfNoJavascripOpen($mode) . "\n" . $text
+    return _wrapInContainerHideIfNoJavascripOpen($mode) . " " . $text
       . _wrapInContainerDivIfNoJavascripClose($mode);
 }
 
@@ -421,7 +421,7 @@
 
 sub _wrapInContentHtmlClose {
     my ($mode) = shift;
-    return "</$mode>\n<!--/twistyPlugin-->";
+    return "</$mode> <!--/twistyPlugin-->";
 }
 
 sub _wrapInContainerHideIfNoJavascripOpen {

-- TWiki:Main/PeterThoeny - 24 Mar 2009

Strangely no checkin info in table. r17892 was for trunk, r17893 for 4.3 branch.

-- TWiki:Main.PeterThoeny - 24 Mar 2009

Ah, it got added while I edited the page. Restored checkin info form field from history.

-- TWiki:Main.PeterThoeny - 24 Mar 2009

ItemTemplate
Summary TwistyPlugin: Twisty can't be placed in TWiki table cells
ReportedBy TWiki:Main.PeterThoeny
Codebase

SVN Range TWiki-5.0.0, Mon, 23 Feb 2009, build 17838
AppliesTo Extension
Component TwistyPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:17892 TWikirev:17893
TargetRelease patch
ReleasedIn 4.3.0
Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2009-04-08 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback