• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6268: Explicit links not updated within noautolink blocks after move/rename

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal New   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Explicit links should always be updated when a Topic is moved/renamed.

<noautolink> means no AUTO linking. It does not mean no linking.

Yet explicit [[...]] enclosed links are not being updated following a Move or Rename of a page. This is inappropriate behaviour.

The code is here:

forEachLine (in lib/TWiki/Render.pm) has the following logic:


        unless( $options->{in_pre} > 0 && !$options->{pre} ||
                $options->{in_verbatim} > 0 && !$options->{verbatim} ||
                $options->{in_literal} > 0 && !$options->{literal} ||
                $options->{in_noautolink} > 0 && !$options->{noautolink} ) {
            $line = &$fn( $line, $options );
        }

And In lib/TWiki/UI/Manage.pm (_updateReferringTopics)

    my $options =
      {
       pre => 1, # process lines in PRE blocks
       oldWeb => $oldWeb,
       oldTopic => $oldTopic,
       newWeb => $newWeb,
       newTopic => $newTopic,
      };

To Test

Is it sufficient to either remove noautolink from that logic OR to add

  noautolink => 1, # process lines in noautolink blocks
to lib/TWiki/UI/Manage.pm (_updateReferringTopics)? Is TWiki smart enough to bypass WikiWords that are not within =&091;[...]] (if not, that's a different bug)

-- TWiki:Main/VickiBrown - 20 May 2009

Co-worker has apparently looked at code and says:

"It's more difficult than just adding noautolink = 1 because of the WikiWords outside of [[]].

IMO the correct fix involves passing a parameter to _updateReferringTopics to say whether or not to rename bare WikiWords.

-- TWiki:Main.VickiBrown - 20 May 2009

ItemTemplate
Summary Explicit links not updated within noautolink blocks after move/rename
ReportedBy TWiki:Main.VickiBrown
Codebase 4.0.5, 4.2.4
SVN Range TWiki-5.0.0, Sat, 18 Apr 2009, build 18024
AppliesTo Engine
Component

Priority Normal
CurrentState New
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r2 - 2009-05-20 - VickiBrown
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback