• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6299: RevCommentPlugin doesn't play nicely with users

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension RevCommentPlugin Normal New   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

RevCommentPlugin doesn't understand automated edits (edits made from other pages or by plugins, not by a human clicking the Edit link)

I have a CommentPlugin template that is appending lines to a table in another topic. Every time a new line is appended, RevCommentPlugin shoves a %META:REVCOMMENT{comments="0"}% entry onto the end of the line, garbaging my table.

Unfortunately, not only doesn't RevCommentPlugin understand (and ignore) edits made by other plugins, there's no way for me to turn this off.

At the very least, if there is no revcomment, the plugin should NOT add anything to the page.

What's breaking things isn't a revcomment, it's an "empty"

   %META:REVCOMMENT{comments="0"}% 

Better, the plugin should have some way to tell if the edit script is actually presenting something onscreen for the user.

Best, there needs to be a way to Turn This Off.

A plugin that is installed globally into a template is no longer a plugin. This extension violates the Principle of Least Surprise.

-- TWiki:Main/VickiBrown - 12 Aug 2009

FYI, I found a workaround to this. My template was

%TMPL:DEF{OUTPUT:topiccomment}%%POS:AFTER%| [[%URLPARAM{"base_topic"}%]] | %DATE% | %WIKIUSERNAME% | %URLPARAM{"comment_text" }% | %REVINFO{topic="%URLPARAM{"base_topic"}%" "$date - $wikiusername"}% | %TMPL:END%

And now it's

%TMPL:DEF{OUTPUT:topiccomment}%%POS:BEFORE%| [[%URLPARAM{"base_topic"}%]] | %DATE% | %WIKIUSERNAME% | %URLPARAM{"comment_text" }% | %REVINFO{topic="%URLPARAM{"base_topic"}%" "$date - $wikiusername"}%  |
%TMPL:END%
And I'm using an Anchor in the target.

Moving the %TMPL:END% to the next line solved the RevCommentPlugin problem. The other changes were necessary to make the table continue to work.

-- TWiki:Main.VickiBrown - 10 Sep 2009

ItemTemplate
Summary RevCommentPlugin doesn't play nicely with users
ReportedBy TWiki:Main.VickiBrown
Codebase 4.2.4
SVN Range TWiki-5.0.0, Sat, 18 Apr 2009, build 18024
AppliesTo Extension
Component RevCommentPlugin
Priority Normal
CurrentState New
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r2 - 2009-09-10 - VickiBrown
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback