• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6737: Broken nested tabs

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension JQueryPlugin Normal Closed   major 6.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

I found a little bug in the implementation of the tabs by twiki. When you do nested tabs, if the javascript blocks like so:

jQuery(function($) { $("#jqTabPane10").tabpane({select:1}); });

There are multiple of these (with different numbers - ...Pane11, etc.). If they are not in the right order, then you get broken nested tabs. On Sandbox.JQueryTabTest2, in the top set of tabs, select Tab 2, then Tab 2.2, and you'll see that things break. On the bottom set of tabs, which are hard-coded, the javascript blocks are in-order. Put block "12" before block "10" - breaks. Not sure how this is handled in the code, so I'm not sure how easy the fix is. Thanks.

-- TWiki:Main/AaronLWalker - 2011-05-31

Thanks Aaron. Confirmed, needs to be fixed.

-- TWiki:Main.PeterThoeny - 2011-06-12

I am copying TWiki:Sandbox.JQueryTabTest2 over to here:

Bad

Tab 1

Tab 1.1

Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Maecenas sit amet tellus id ante pretium aliquam. Etiam interdum, turpis in varius facilisis, nibh neque tincidunt sapien, et viverra libero justo et leo.

Tab 1.2

tristique ligula suscipit suscipit. Donec et tortor. Integer eros eros, commodo in, aliquam sit amet, facilisis et, magna. Sed nisl. Pellentesque mattis, quam ut nonummy rutrum, sem felis ultrices nunc, sed mollis dolor diam et purus.

Tab 1.3

Aenean urna. Morbi eros. Quisque mauris magna, rhoncus vitae, ullamcorper ac, volutpat quis, nibh. end of tab 1

Tab 2

Donec ultrices mollis velit.

Tab 2.1

Some stuff

Tab 2.2

More stuff

Tab 2.3

Finally, the end of the stuff.
end of tab 2

Tab 3

Sed a nisi. Maecenas posuere vehicula orci. end of tab 3

Tab 4

Sed non ante non nibh pharetra facilisis. end of tab 4

Good

Tab 1

Tab 1.1

Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Maecenas sit amet tellus id ante pretium aliquam. Etiam interdum, turpis in varius facilisis, nibh neque tincidunt sapien, et viverra libero justo et leo.

Tab 1.2

tristique ligula suscipit suscipit. Donec et tortor. Integer eros eros, commodo in, aliquam sit amet, facilisis et, magna. Sed nisl. Pellentesque mattis, quam ut nonummy rutrum, sem felis ultrices nunc, sed mollis dolor diam et purus.

Tab 1.3

Aenean urna. Morbi eros. Quisque mauris magna, rhoncus vitae, ullamcorper ac, volutpat quis, nibh. end of tab 1

Tab 2

Donec ultrices mollis velit.

Tab 2.1

Some stuff

Tab 2.2

More stuff

Tab 2.3

Finally, the end of the stuff.
end of tab 2

Tab 3

Sed a nisi. Maecenas posuere vehicula orci. end of tab 3

Tab 4

Sed non ante non nibh pharetra facilisis. end of tab 4

-- TWiki:Main.PeterThoeny - 2013-09-28

I fixed this by adding the $requires parameter with the previous tab pane ID, thus enforcing the sequential order of tab pane jQuery calls in the header.

-- TWiki:Main.PeterThoeny - 2013-09-28

ItemTemplate
Summary Broken nested tabs
ReportedBy TWiki:Main.AaronLWalker
Codebase 5.0.2, 4.3.1
SVN Range TWiki-5.1.0-trunk, Sun, 22 May 2011, build 21317
AppliesTo Extension
Component JQueryPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:26438 TWikirev:26439
TargetRelease major
ReleasedIn 6.0.0
Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2013-10-15 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback