• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6944: Get script URL with TWiki::Func::getMasterWebScriptUrl

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension CommentPlugin Low Closed   patch 5.1.1

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

TWiki::Func::getScriptUrl doesn't work when current twiki web is not working as a master web. Refer TWiki:Codev.ReadOnlyAndMirrorWebs for the details. I changed TWiki::Func::getScriptUrl to TWiki::Func::getMasterWebScriptUrl

-- TWiki:Main/YaojunFei - 2012-09-26

Thanks Yaojun.

Plugins should be maintained so that they can be installed on older and newer TWiki versions. This is especially true for core plugins. Please call TWiki::Func::getScriptUrl or TWiki::Func::getMasterWebScriptUrl conditionally based on $TWiki::Plugins::VERSION.

I have seen you checked in so far into trunk. This is a core plugin, e.g. shipped with TWiki release. Please specify if only trunk feature or also TWiki-5.1 branch. Extension enhancements are typically done in both. But don't do this weekend in branch due to release build we have this weekend.

Once done, please set to "Waiting for release" so that it can be tracked properly for the next release.

-- TWiki:Main.PeterThoeny - 2012-10-06

Call TWiki::Func::getMasterWebScriptUrl only if $TWiki::Plugins::VERSION >= 1.4

-- TWiki:Main.YaojunFei - 2012-10-08

TWiki::Func::getMasterWebScriptUrl() is not really part of $TWiki::Plugins::VERSION 1.4. I use "defined(&TWiki::Func::getContentMode)" instead, because if TWiki::Func::getContentMode() is defined, TWiki::Func::getMasterWebScriptUrl() must exist also.

-- TWiki:Main.YaojunFei - 2012-10-08

ItemTemplate
Summary Get script URL with TWiki::Func::getMasterWebScriptUrl
ReportedBy TWiki:Main.YaojunFei
Codebase ~twiki4, 5.1.1
SVN Range TWiki-5.1.1-trunk, Tue, 25 Sep 2012, build 23433
AppliesTo Extension
Component CommentPlugin
Priority Low
CurrentState Closed
WaitingFor

Checkins TWikirev:23438 TWikirev:23439 TWikirev:23569 TWikirev:23570
TargetRelease patch
ReleasedIn 5.1.1
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2012-12-16 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback