• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7427: Too small or too big font with twikiSubmit class on button tag and the a tag

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension PatternSkin Normal Closed   patch 6.0.1

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Test case:

  • - using button tag
  • - using input type submit tag

  • Restore - using a tag
  • - using input type submit tag

Using class="twikiButton" on input type submit tag produces a too small font in FF on Mac, and a slightly too big font on the a tag.

On the other hand, using class="twikiButton" on the a tag produces a way too big font on iOS Safari.

-- TWiki:Main/PeterThoeny - 2014-02-04

Fix tested on:

  • FF 26.0 on Mac
  • Safari 6.1.1 on Mac
  • Google Chrome on Mac 34.0
  • FF 25.0 on Win XP
  • IE 8.0 on Win XP

-- TWiki:Main.PeterThoeny - 2014-02-04

This is now in SVN trunk & 6.0 branch. Package released as well.

-- TWiki:Main.PeterThoeny - 2014-02-04

I don't see the button change on Windows 7. Screen capture below has Firefox on top, IE11 on bottom. F12 tools show the style is being applied. I played with F12 editing on Firefox - it takes something like 105% to get the I and the icon proportions to look about right.

With respect to packaging, see my comments in EcoPluginDev - while I'm OK with distributing a patch for PatternSkin with the plugin, this skin-specific, temporary patch should not be hard-coded in the plugin.

Capture.PNG

By the way, the ATTACH took several minutes to effect - for a 20KB image. Might want to check the server logs to figure out why.

-- Timothe Litt - 2014-02-04

For comparison, this is the look of an unpatched PatternSkin and unpatched EcoTrashPlugin on Chrome:

  • font-size-chrome.png:
    font-size-chrome.png

Similar with FF.

-- TWiki:Main.PeterThoeny - 2014-02-05

I am aware of the delay with attachments. Could not diagnose the cause. It happens sporadically, just now it happened again to me too.

-- TWiki:Main.PeterThoeny - 2014-02-05

ItemTemplate
Summary Too small or too big font with twikiSubmit class on button tag and the a tag
ReportedBy TWiki:Main.PeterThoeny
Codebase ~twiki4, 6.0.0
SVN Range TWiki-6.0.1-trunk, Thu, 09 Jan 2014, build 26720
AppliesTo Extension
Component PatternSkin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:26988 TWikirev:26989 TWikirev:26990 TWikirev:26991 TWikirev:26992 TWikirev:26993 TWikirev:26994 TWikirev:26995
TargetRelease patch
ReleasedIn 6.0.1
Edit | Attach | Watch | Print version | History: r14 < r13 < r12 < r11 < r10 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r14 - 2014-10-06 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback