• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7523: Unit tests: EmptyTests fails; ManagingWebs can't take TWiki as template web

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal New   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The setup routine in EmptyTests,pm fails with the message:

RCS: copy /media/haj/linuxdevel/twiki/trunk/core/pub/TWiki/BehaviourContrib/cssQuery to /media/haj/linuxdevel/twiki/trunk/core/pub/Temporarytwikiweb/BehaviourContrib/cssQuery failed: Is a directory at /media/haj/linuxdevel/twiki/trunk/core/lib/TWiki/Store/RcsFile.pm line 888.

The reason is that, in the SVN tree, BehaviourContrib breaks a silent assumption on web creation:

  • In the example setup, there's a routine to "copy a system web", which tries to create a new web based on the TWiki web.
  • Web creation assumes that the pub directory holds just files, and no directories
  • When it comes to BehaviourContrib, this assumption fails and the test bails out in the setup routine.

I don't think that the TWiki web is a good representative for such a test case at all, because it is pretty big and running that as part of any "unit" test will take considerable time (and space). However, there may be good use for copying the TWiki web in case of local changes to the documentation which should't get lost with an upgrade. So I tested the same thing with ManagingWebs on my pilot installation of TWiki 6.0.0, which also offers TWiki as a base web - and this also fails:

TWiki detected an internal error - please check your TWiki logs and webserver logs for more information.

RCS: copy path to path failed: Is a directory

Bottom line: Webs which contain directories in the pub folder of any of their topics are no longer suitable as template webs. There is no easy check for this other than trial-and-error. In the TWiki 6.0.0 distribution, the offending subdirectory of BehaviourContrib doesn't exist, but plenty of others fill the void: DatePickerPlugin, JQueryPlugin, JSCalendarContrib, TinyMCEPlugin, as far as a default installation is concerned.

I am assigning this to "Engine" because the unit test just pointed me towards the bug, the test case itself is innocent.

-- TWiki:Main/HaraldJoerg - 2014-06-22

ItemTemplate
Summary Unit tests: EmptyTests fails; ManagingWebs can't take TWiki as template web
ReportedBy TWiki:Main.HaraldJoerg
Codebase ~twiki4, 6.0.0
SVN Range TWiki-6.0.1-trunk, Sun, 15 Jun 2014, build 27651
AppliesTo Engine
Component

Priority Normal
CurrentState New
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Topic revision: r1 - 2014-06-22 - HaraldJoerg
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback