• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7562: TWiki::Render::summariseChanges() needs safeguard

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   patch 6.0.1

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

TWiki::Render::summariseChanges() calls TWiki::Merge::simpleMerge(), which calls Algorithm::Diff::traverse_balanced(), which may cause out-of-memory with a topic bigger than two megabytes. The limit may vary depending on the version of Algorithm::Diff and other factors. So TWiki::Render::summariseChanges() should have a way to omit a call to TWiki::Merge::simpleMerge() depending on the size of the topic text.

For that, $TWiki::cfg{SummariseChangesLimit} is introduced to specify the limit. Either of the compared versions is bigger than the limit, the summary is "Text is too big to show the difference." or a translation of it. If $TWiki::cfg{SummariseChangesLimit} is zero or undefined, the prior behavior remains -- TWiki::Merge::simpleMerge() is called regardless of text size.

At least, MailerContrib's tools/mailnotify ends prematurely if a large topic is updated since its last run under certain circumstances.

-- TWiki:Main/HideyoImazu - 2014-10-02

ItemTemplate
Summary TWiki::Render::summariseChanges() needs safeguard
ReportedBy TWiki:Main.HideyoImazu
Codebase ~twiki4
SVN Range TWiki-6.0.1-trunk, Mon, 29 Sep 2014, build 28107
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:28143 TWikirev:28144
TargetRelease patch
ReleasedIn 6.0.1
Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2018-07-17 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback