• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7631: Attach with drag'n'drop writes a line to the error log every time

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension PatternSkin Low New      

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The nice feature to attach files with drag'n'drop has a minor wart: Every time it is used, a line in the error log says:
ERROR: http://site/bin/Web/Topic at /home/haj/devel/twiki/trunk/core/lib/TWiki.pm line 928.

The reason is that to make it work, the template now has an additonal parameter noredirect=1, apparently to delay redirection by the upload process before all attachments have been processed. This trips over a smelly rock in TWiki.pm:

    # SMELL: if noredirect is set, don't generate the redirect, throw an
    # exception instead. This is a HACK used to support TWikiDrawPlugin.
    # It is deprecated and must be replaced by REST handlers in the plugin.
    if( $query->param( 'noredirect' )) {
        die "ERROR: $url";
        return;
    }

It seems that the new way to attach files also relies on said "HACK", only that it has no chance to use REST handlers. The question arises why the code insists on dying? I guess we could as well make it a feature.

-- TWiki:Main/HaraldJoerg - 2015-04-01

ItemTemplate
Summary Attach with drag'n'drop writes a line to the error log every time
ReportedBy TWiki:Main.HaraldJoerg
Codebase ~twiki4
SVN Range TWiki-6.0.1-trunk, Sat, 21 Mar 2015, build 28827
AppliesTo Extension
Component PatternSkin
Priority Low
CurrentState New
WaitingFor

Checkins

TargetRelease

ReleasedIn

Topic revision: r1 - 2015-04-01 - HaraldJoerg
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback