• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7759: EditTablePlugin uses viewauth unnecessarily, brings down TWiki if headerrows and footerrows are inappropriate

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine EditTablePlugin Normal Closed   patch 6.1.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

EditTablePlugin uses viewauth even if the user is already authenticated. It should simply use view for authenticated users.

EditTablePlugin brings down TWiki if TABLE{...} specifies headerrows and footerrows inappropriately. For example, if you edit the table below, TWiki goes down.

%TABLE{headerrows="1" footerrows="1"}%
%EDITTABLE{}%
| *Name* | *Value* |

-- TWiki:Main/HideyoImazu - 2016-11-14

The viewauth case was done because of Apache login (like here on develop TWiki). If there is a need to use just view for authenticated users I think it should be done conditionally for template login.

-- TWiki:Main.PeterThoeny - 2016-11-14

Peter, can you please elaborate? I viewed http://develop.twiki.org/~twiki/cgi-bin/view/Sandbox/HideyoImazu unauthenticated, clicked the edit table button, was prompted for an ID and a password, entered them, and was able to edit the table.

-- TWiki:Main.HideyoImazu - 2016-11-14

Yes, that seems to work OK. So never mind!

-- TWiki:Main.PeterThoeny - 2016-11-15

ItemTemplate
Summary EditTablePlugin uses viewauth unnecessarily, brings down TWiki if headerrows and footerrows are inappropriate
ReportedBy TWiki:Main.HideyoImazu
Codebase ~twiki4
SVN Range TWiki-6.0.2-trunk, Fri, 29 Jul 2016, build 30222
AppliesTo Engine
Component EditTablePlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:30270 TWikirev:30271
TargetRelease patch
ReleasedIn 6.1.0
Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2018-07-17 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback