• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6754: Action comment template in CommentPlugin is missing %ENDACTION%

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension CommentPlugin Normal Closed   patch 5.1.0, 5.0.2

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

In the CommentPluginTemplate currently installed on twiki.org the output section for the action comment type is:

%TMPL:DEF{OUTPUT:action}%%POS:BEFORE%%AC%NOP%TION{who="%URLPARAM{"action_who"}%" due="%URLPARAM{"action_due"}%"}% %URLPARAM{"action_comment" newline="<br />"}%<br />- Created by %WIKIUSERNAME%, %SERVERTIME%
%TMPL:END%

However this creates incorrect output as the %ENDACTION% varibale is missing so all of the rest of the text on the page is presented as part of the action.

Changing the definition to read:

%TMPL:DEF{OUTPUT:action}%%POS:BEFORE%%AC%NOP%TION{who="%URLPARAM{"action_who"}%" due="%URLPARAM{"action_due"}%"}% %URLPARAM{"action_comment" newline="<br />"}%<br />- Created by %WIKIUSERNAME%, %SERVERTIME%
%END%NOP%ACTION%
%TMPL:END%

produces the expected action table display.

-- TWiki:Main/JohnRouillard - 2011-06-16

Thanks John! This is now in SVN trunk and 5.0 branch. Uploaded to twiki.org as well.

-- TWiki:Main.PeterThoeny - 2011-06-17

ItemTemplate
Summary Action comment template in CommentPlugin is missing %ENDACTION%
ReportedBy TWiki:Main.JohnRouillard
Codebase ~twiki4, 5.0.2
SVN Range TWiki-5.1.0-trunk, Mon, 13 Jun 2011, build 21497
AppliesTo Extension
Component CommentPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:21515 TWikirev:21516 TWikirev:21517 TWikirev:21518 TWikirev:21519
TargetRelease patch
ReleasedIn 5.1.0, 5.0.2
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r8 - 2011-08-22 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2024 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback