After switching to TWiki4 and enabling {IDsInUrls} I noticed that the topic links included in the emails sent out by the mailnotify script were invalid. For instance:
http://shake200.esscc.uq.edu.au/twiki/bin/?TWIKISID=04ed1ee4f8f4077a543fa8b19ef1fa4a
Instead of:
http://shake200.esscc.uq.edu.au/twiki/bin/view/ESSCC/WebNotify
Turning
IDsInURLs off again resulted in the correct links being used in the E-mails. As such I appear to be able to replicate this on my install at will.
Here's the fix I created:
lib/TWiki/Contrib/MailerContrib/Change.pm
***************
*** 127,132 ****
--- 127,133 ----
}
}
$html =~ s/%REVISION%/$frev/g;
+ $html = $this->{SESSION}->handleCommonTags( $html, $this->{WEB}, $this->{TOPIC} );
$html = $this->{SESSION}->{renderer}->getRenderedVersion( $html );
$html =~ s/%TEXTHEAD%/$this->{HTML_SUMMARY}/g;
It appears that getRenderedVersion called without a call the handleCommonTags corrupts the %SCRIPTURL{"view"}% tag before it can be processed.
This file is unmodified in 4.0.4 but I haven't tried in that version.
Good catch, thanks. Not sure why it took so long to get to this :-/
CC
4.1.0 released
KJL