• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Every time i've tried BulkRegister, i've had no success, and a maxed out CPU. I've just fored out one reason - the DelimitedFile::read assumes the table starts on the first line - and if not, you get an infinite loop frown

i've gone for a dumb solution to this

--- TWiki/Data/DelimitedFile.pm (revision 10222)
+++ TWiki/Data/DelimitedFile.pm (working copy)
@@ -42,9 +42,14 @@
     my @content = split $rowend, $content;
     
     my $headerRow  = shift @content;
+    until ($headerRow =~ /\Q$delimiter\E/ ) {
+       $headerRow  = shift @content;
+    }
     
     $headerRow =~ s/\x0a*//g;
     $headerRow =~ s/\x0d*//g;

but this suggests to me that without a proper test suite, this code should not be trusted by anyone, for anything frown


This code wants "the first table in the topic". Is there a way to address and pass that?

-- MC

ItemTemplate
Summary TWiki::Data::DelimitedFile is not as robust as it could be
ReportedBy TWiki:Main.SvenDowideit
Codebase ~twiki4
SVN Range Sat, 06 May 2006 build 10108
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins 10264, 10265
TargetRelease patch
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r5 - 2006-06-06 - SteffenPoulsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2024 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback