The
NewUserTemplate has this meta data format:
META:FIELD{name="OrganisationURL" attributes="" title="<nop>OrganisationURL" value=""}
After a user gets registered by the agent, we get this format:
META:FIELD{name="OrganisationURL" title="Organisation URL" value=""}
Once the topic gets edited, we get this format:
META:FIELD{name="OrganisationURL" attributes="" title="<nop>OrganisationURL" value=""}
Rdiff shows that the whole form changed as you can see with this example:
http://twiki.org/cgi-bin/rdiff/Main/JeongYoungJin
http://twiki.org/cgi-bin/rdiff/Main/JeongYoungJin?render=debug
There are three problems:
1. The registration does not use the same form format as the template:
- It strips the
attributes=""
- It strips the
<nop>
from OrganisationURL
-
title="<nop>OrganisationURL"
vs title="Organisation URL"
(The spaced field name is perferred, as it was in Cairo)
2. On first topic save, the form changes back to the template format, rendering the diff useless.
--
PTh
I removed the field name spacing from registration. I hope this doesn't break previously registered users! (it shouldn't)
CC
I think this does not solve the issue, and will probably bring a new issue if the form field happens to have a space.
I think the registration process should use the proper meta form functions, then it is up to the meta class to space (or not space) the title. This should fix the three problems I stated earlier.
--
PTh
Partial fix by adding attributes parameter.
Nevertheless, all form fields still show as changed on first edit-save because the leading
<nop>
is missing.
--
PTh
I am working on a fix now.
--
PTh
I changed the code to use the form fields of the
NewUserTemplate instead of the form definition. This fixes the inconsistency issues with <nop>, attributes parameter, and spacing.
--
PTh