Test case:
- Create lease for a user.
- As a different user, try to edit topic.
- The oopsleaseconflict dialog is brought up.
- Click on the "edit anyway" button
- A new version of the oops dialog is brought up, which is not instantiated.
- this is strange as the url shown is
http://localhost/twiki4le/bin/edit/Test/EditTableTest3
but the topic shown is the oops dialog.
OK. Here is the problem. When clicking "edit anyways", the form sends
breaklock
with "on" which is good, but it also sends
all the parameters that were given to the leaseconflict template, including the name of the template being
oopsleaseconflict
. That causes the oopstemplate to be loaded again, rather than the edit template. We cannot use the parameter
template
to create the oopstemplate. --
TW
What I did was rename the parameter to indicate the oops template to use to
oopstemplate
thus avoiding the conflict with the edit template. --
TW
And thus you created a new problem because the templates still refer to
template=oopsmore
. Any old skin will refer to that template that way.
You cannot just change it. At least it should be deprecated so the old param is still valid.
AC
Arthur, thanks. Will roll back. --
TW
However, I believe this is not an issue of deprecation, as the templates are not documented to have this parameter. And even if we did, it is a bug and we cannot just keep bugs around. Once we figure out how to solve the
oopsleaseconflict
in general, I will change all the templates also... --
TW
Rolled back changes to discuss whether this is the right approach. I still think so, but will have to change all templates, as Arthur pointed out.
Please comment.
The list of affected templates if above approach is chosen:
- backlinksallwebs.classic.tmpl
- backlinksallwebs.pattern.tmpl
- backlinksallwebs.tmpl
- backlinksweb.classic.tmpl
- backlinksweb.pattern.tmpl
- backlinksweb.tmpl
- oopschangelanguage.tmpl
- oopsmore.classic.tmpl
- oopsmore.nat.tmpl
- oopsmore.tmpl
- oopsmorebacklinks.pattern.tmpl
- rdiff.classic.tmpl
- rdiff.pattern.tmpl
- rdiff.tmpl
- view.classic.tmpl
- view.plain.tmpl
- view.tmpl
- viewtopicactionbuttons.pattern.tmpl
OK. In order to keep havoc to a minimum, I suggest an alternative implementation. In
TWiki::UI::Oops::oops
, delete the template parameter, which causes the default edit template to be loaded.
Note that clicking on "Try" still does not work due to Item2614 and Item2295. I have fixes for those.
--
TW
4.1.0 released
KJL