The sent mails are not correct (no Changed by "user") due to a
typo in templates/mailnotify.tmpl:
Line 18:
<b>%MAKETEXT{"Changed by"}:%</b>
needs to be
<b>%MAKETEXT{"Changed by:"}%</b>
--
ChristianZiemski - 09 Nov 2006
Can you explain why you think they are not correct? 'Changed by' is the string in the translations file, not 'Changed by:', so %MAKETEXT{"Changed by:"}% will always expand to the English. So it would appear to be correct at the moment.
--
CrawfordCurrie - 11 Nov 2006
If the translated phrase is "Changed By" then I guess the proper overall string should be
<b>%MAKETEXT{"Changed by"}%:</b>
. I'll check in this change (along with a few other corrections to the docs) this weekend.
--
LynnwoodBrown - 11 Nov 2006
Crawford:
The original is simply a syntax error: The colon invalidates the expression because it is between the closing curly brace and the percent sign.
--
ChristianZiemski - 13 Nov 2006
Hi there, I have checked this today with my local installation and all strings in the translation files (sure for de.po) are "Changed
:" and "Changed by
:". So I greped through the files in templates and there are still some files with wrong typo, like
ChristianZiemski has given. After changing the typo to
%MAKETEXT{"Changed by:"}%
it worked pretty fine.
--
ThomasFreudenberg - 13 Nov 2006
Very odd; de.po contains "Changed by:" and "Changed by". But TWiki.pot (the master) only contains "Changed by". So that's the one I used.
CC
Thanks, Christian. Fixed now.
CC
4.1.0 released
KJL