• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5254: Javascript error when editing in pickaxe mode

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension TinyMCEPlugin Normal Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Edit a topic in Wysiwyg

Hit the pickaxe

Click somewhere in the tml and type for example a space.

Everytime I try I see a Javascript error reported in IE saying "Line 190, char1, object expected"

Taking into consideration the severe errors I have seen in practical use - this one should be at least analysed by someone that knows Javascript.

-- TWiki:Main/KennethLavrsen - 16 Jan 2008

If a Javascript knowledgable can evaluate the error and it is harmless then downgrade to normal. If it is harmful (potential loss of work) then please fix before 4.2.0. You have hours, not days.

-- TWiki:Main.KennethLavrsen - 16 Jan 2008

The error is caused by the call of handleKeyDown() in the text area field.

<textarea class="twikiTextarea twikiEditboxStyleProportional" id="topic" name="text" rows="22" cols="70" style='width:99%' onkeydown='handleKeyDown(event)'>

It looks like handleKeyDown() is not defined.

-- TWiki:Main.FrankSpangenberg - 18 Jan 2008

Frank is right. handlekeyDown is defined in twiki_edit.js, which is not included. The function simply filters the escape key in the edit box, because browsers have differing interpretations.

The error is irritating, but no more serious than that. If you are using IE with debugging enabled, it will halt the process, which is annoying, so it should be fixed. The fix is itself very low risk, as it's a copy-paste of existing code.

CC

Fixed (you may need to restart your browser to force a JS reload)

CC

ItemTemplate
Summary Javascript error when editing in pickaxe mode
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.2.0, ~twiki4
SVN Range TWiki-4.3.0, Tue, 15 Jan 2008, build 16238
AppliesTo Extension
Component TinyMCEPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:16265 TWikirev:16266
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r6 - 2008-01-21 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2024 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback